Adding button to link accounts from user settings#19792
Merged
Conversation
zeripath
reviewed
May 24, 2022
6543
reviewed
May 24, 2022
zeripath
approved these changes
May 24, 2022
wxiaoguang
reviewed
May 25, 2022
Contributor
There was a problem hiding this comment.
Generally L-G-T-M. Some CSS/HTML suggestions.
ps: you could also allow Edit by maintainers for your PR, then maintainers can update / merge it easily. If the PR can not be edited by maintainers, you would do merge from main every time if main branch changes.
Contributor
|
I think this is rather a kind/feature than kind/enchantment. |
fdfb9b3 to
34115f4
Compare
Contributor
Author
@wxiaoguang have added your suggestions and rebased the branch against master |
6543
approved these changes
May 28, 2022
Contributor
|
Fix i18n for Link Account button, re-format tmpl #19835 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 29, 2022
* giteaofficial/main: Fix i18n for Link Account button, re-format tmpl (go-gitea#19835) [skip ci] Updated translations via Crowdin Adding button to link accounts from user settings (go-gitea#19792) fix(telegram): fix link bot to release tag (go-gitea#19830) Fix raw endpoint PDF file headers (go-gitea#19825)
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* Adding button to link accounts from user settings * Only display button to link user accounts when at least one OAuth2 provider is active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #17004 by adding an "Link Account" button to the list of linked accounts in the user's settings under "Security".