Localize all timestamps#21440
Merged
Merged
Conversation
Member
Member
Author
|
I read both PRs you linked. About the following comment: Originally posted by @silverwind in #21429 (comment) If you are still doing that then it's worth merging this as it's simply building on Any solution of a different implementation would still have to include this JS so I suggest merging this for now #21410 did this for the activity page, this just does it for all other timestamps, easy win |
Member
|
If we decide for the JS solution, we can certainly go ahead with this already. |
6cd0fff to
24469d9
Compare
Member
Author
|
wxiaoguang
approved these changes
Oct 15, 2022
d9647d2 to
9e14b51
Compare
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Signed-off-by: Yarden Shoham <hrsi88@gmail.com>
Gusted
reviewed
Oct 15, 2022
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Co-authored-by: Gusted <williamzijl7@hotmail.com>
Gusted
approved these changes
Oct 15, 2022
Gusted
left a comment
Contributor
There was a problem hiding this comment.
Alright LGTM. Given the other PR to make the JS execution faster, the concern of FOUC shouldn't be that big, if the other PR is merged before 1.18
delvh
reviewed
Oct 16, 2022
Member
|
make L-G-T-M work |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following
We are now able to localize all timestamps. Some examples:
short-dateformat, French, user profile page:date-timeformat, Portuguese, mirror repository settings page:Signed-off-by: Yarden Shoham hrsi88@gmail.com