Replace yaml.v2 with yaml.v3#21832
Merged
Merged
Conversation
Contributor
|
Related: |
Member
|
that wont work as long as goldmark do use the old one |
Member
Author
I might know why, v2 will decode a map into interface with type Not really sure, I'll take some time to figure it out. |
Member
Author
I saw your attempt in yuin/goldmark-meta#6. But I mean avoid using both versions in Gitea directly, I know we can't get rid of v2 version completely. |
Member
|
But at least, we can remove all direct dependencies on v2. |
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
There are two little differences between yaml.v2 and yaml.v3 which broke the tests:
There's an example: https://go.dev/play/p/PqLD6tR75xF . |
lunny
approved these changes
Nov 21, 2022
fsologureng
pushed a commit
to fsologureng/gitea
that referenced
this pull request
Nov 22, 2022
I don't see why we have to use two versions of yaml. The difference between the two versions has nothing to do with our usage.
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 23, 2022
* giteaofficial/main: Handle empty author names (go-gitea#21902) Move all remaining colors into CSS variables (go-gitea#21903) Add option to enable CAPTCHA validation for login (go-gitea#21638) Prepend refs/heads/ to issue template refs (go-gitea#20461) Fixes go-gitea#21895: standardize UTC tz for util tests (go-gitea#21897) Clarify logging documentation (go-gitea#21665) Update JS dependencies (go-gitea#21881) Webhook list enhancements (go-gitea#21893) Embed Matrix icon as SVG (go-gitea#21890) fix(web): add `alt` for logo in home page (go-gitea#21887) Improvements for Content Copy (go-gitea#21842) Replace yaml.v2 with yaml.v3 (go-gitea#21832) Allow disable RSS/Atom feed (go-gitea#21622) Consolidate security-check into checks-backend (go-gitea#21882)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see why we have to use two versions of yaml. The difference between the two versions has nothing to do with our usage.