Ensure delete user deletes all comments (#21067)#21068
Merged
Merged
Conversation
jolheiser
approved these changes
Sep 5, 2022
zeripath
reviewed
Sep 5, 2022
zeripath
approved these changes
Sep 5, 2022
zeripath
left a comment
Contributor
There was a problem hiding this comment.
Approved as this fixes a fairly serious bug - BUT the delete comment code is really quite inefficient. There is no need get all of this stuff out of the DB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #21067
There is a mistake in the batched delete comments part of DeleteUser which causes some comments to not be deleted
The code incorrectly updates the
startof the limit clause resulting in most comments not being deleted.should be: