Skip to content

Respect REQUIRE_SIGNIN_VIEW for packages (#20873)#21232

Merged
wxiaoguang merged 2 commits into
go-gitea:release/v1.17from
KN4CK3R:backport-0a9a86b
Sep 23, 2022
Merged

Respect REQUIRE_SIGNIN_VIEW for packages (#20873)#21232
wxiaoguang merged 2 commits into
go-gitea:release/v1.17from
KN4CK3R:backport-0a9a86b

Conversation

@KN4CK3R

@KN4CK3R KN4CK3R commented Sep 21, 2022

Copy link
Copy Markdown
Member

Backport of #20873

@KN4CK3R @lafriks @wxiaoguang
Respect REQUIRE_SIGNIN_VIEW for packages (go-gitea#20873)
ca25b04 
Fix go-gitea#20863

When REQUIRE_SIGNIN_VIEW = true, even with public repositories, you can only see them after you login. The packages should not be accessed without login.

Co-authored-by: Lauris BH <lauris@nix.lv>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
@KN4CK3R KN4CK3R added this to the 1.17.3 milestone Sep 21, 2022
@lafriks

lafriks commented Sep 21, 2022

Copy link
Copy Markdown
Member

go lint failure

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 21, 2022
@KN4CK3R

KN4CK3R commented Sep 21, 2022

Copy link
Copy Markdown
Member Author

For files not touched by this PR. Could your restart the build? go fmt changes nothing on my side.

@wxiaoguang

wxiaoguang commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

I think the reason is that the gitea/test_env image used by drone pipeline has just upgraded the Golang to 1.19.x

Go 1.19 has different go fmt output.

wxiaoguang
wxiaoguang approved these changes Sep 21, 2022
View reviewed changes

@wxiaoguang wxiaoguang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM while the lint failure should be fixed in another PR (when using Go 1.19.x fmt, more than 10 files will be changed)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 22, 2022
@wxiaoguang

wxiaoguang commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

LGTM while the lint failure should be fixed in another PR (when using Go 1.19.x fmt, more than 10 files will be changed)

Go 1.19 fmt fix:

@wxiaoguang wxiaoguang merged commit bdf3be5 into go-gitea:release/v1.17 Sep 23, 2022
@KN4CK3R KN4CK3R deleted the backport-0a9a86b branch September 23, 2022 06:05
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug

Projects

None yet

Milestone

1.17.3

Development

Successfully merging this pull request may close these issues.

6 participants

@KN4CK3R @lafriks @wxiaoguang @lunny @GiteaBot @techknowlogick