Skip to content

Add Conda package registry#22262

Merged
jolheiser merged 12 commits into
go-gitea:mainfrom
KN4CK3R:feature-conda
Feb 1, 2023
Merged

Add Conda package registry#22262
jolheiser merged 12 commits into
go-gitea:mainfrom
KN4CK3R:feature-conda

Conversation

@KN4CK3R

@KN4CK3R KN4CK3R commented Dec 28, 2022

Copy link
Copy Markdown
Member

This PR adds a Conda package registry.

grafik

@KN4CK3R KN4CK3R added type/feature Completely new functionality. Can only be merged if feature freeze is not active. topic/packages labels Dec 28, 2022
@KN4CK3R KN4CK3R added this to the 1.19.0 milestone Dec 28, 2022
@KN4CK3R KN4CK3R mentioned this pull request Dec 29, 2022
Open
26 tasks
@codecov-commenter

codecov-commenter commented Dec 29, 2022

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@47efba7). Click here to learn what that means.
The diff coverage is 76.90%.

@@           Coverage Diff           @@
##             main   #22262   +/-   ##
=======================================
  Coverage        ?   47.37%           
=======================================
  Files           ?     1046           
  Lines           ?   142794           
  Branches        ?        0           
=======================================
  Hits            ?    67653           
  Misses          ?    66966           
  Partials        ?     8175
Impacted Files Coverage Δ
models/packages/package.go 49.01% <0.00%> (ø)
services/forms/package_form.go 0.00% <ø> (ø)
modules/packages/conda/metadata.go 70.79% <70.79%> (ø)
routers/api/packages/conda/conda.go 74.00% <74.00%> (ø)
routers/api/packages/api.go 90.80% <97.22%> (ø)
models/packages/conda/search.go 100.00% <100.00%> (ø)
models/packages/descriptor.go 66.66% <100.00%> (ø)
modules/setting/packages.go 86.04% <100.00%> (ø)
routers/api/v1/packages/package.go 88.82% <100.00%> (ø)
services/packages/packages.go 55.79% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2022
zeripath
zeripath reviewed Dec 29, 2022
View reviewed changes
Comment thread modules/packages/conda/metadata.go Outdated
@KN4CK3R KN4CK3R mentioned this pull request Dec 29, 2022
Merged
zeripath
zeripath reviewed Dec 29, 2022
View reviewed changes

@zeripath zeripath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I don't know how many files these tar packages could have but it seems reasonable to shortcut the tar reader once the these two files have been checked.

Comment thread modules/packages/conda/metadata.go
Comment thread modules/packages/conda/metadata.go
zeripath
zeripath reviewed Dec 29, 2022
View reviewed changes
Comment thread routers/api/packages/api.go Outdated
zeripath
zeripath reviewed Dec 29, 2022
View reviewed changes
Comment thread routers/api/packages/conda/conda.go
lunny
lunny reviewed Jan 4, 2023
View reviewed changes
Comment thread modules/packages/conda/metadata.go
lunny
lunny reviewed Jan 4, 2023
View reviewed changes
Comment thread routers/api/packages/conda/conda.go
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 27, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jan 31, 2023
@lunny

lunny commented Jan 31, 2023

Copy link
Copy Markdown
Member

Please resolve the conflicts

@lunny

lunny commented Feb 1, 2023

Copy link
Copy Markdown
Member

CI failure is related

@jolheiser

jolheiser commented Feb 1, 2023

Copy link
Copy Markdown
Member

🎺 🤖

@jolheiser jolheiser merged commit 6ba9ff7 into go-gitea:main Feb 1, 2023
@jolheiser jolheiser removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 1, 2023
@KN4CK3R KN4CK3R deleted the feature-conda branch February 2, 2023 17:23
@kirkryan kirkryan mentioned this pull request Apr 19, 2023
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@zeripath zeripath zeripath left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.19.0

Development

Successfully merging this pull request may close these issues.

8 participants

@KN4CK3R @codecov-commenter @lunny @jolheiser @silverwind @zeripath @GiteaBot @6543