Fix intermittent panic in notify issue change content#23019
Merged
techknowlogick merged 4 commits intoFeb 21, 2023
Merged
Conversation
Ensure that issue pullrequests are loaded before trying to set the self-reference. Signed-off-by: Andrew Thornton <art27@cantab.net>
KN4CK3R
approved these changes
Feb 20, 2023
delvh
reviewed
Feb 20, 2023
delvh
left a comment
Member
There was a problem hiding this comment.
I don't quite understand the changes in this PR:
- Why was the indentation in
LoadPullRequestincreased? It doesn't change any logic… - Why were the two unrelated lines in
services/webhook/notifier.goremoved?
Member
|
LoadPullRequest does the assignment already.
|
delvh
approved these changes
Feb 20, 2023
Member
|
Please send backport |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 21, 2023
* upstream/main: (23 commits) add margin top to the top of branches (go-gitea#23002) Add me to maintainers (go-gitea#23026) Render access log template as text instead of HTML (go-gitea#23013) Use `gt-relative` class instead of the ambiguous `gt-pr` class (go-gitea#23008) Fix intermittent panic in notify issue change content (go-gitea#23019) Improve pull_request_template.md (go-gitea#22888) Hide 2FA status from other members in organization members list (go-gitea#22999) handle deprecated settings (go-gitea#22992) Add scopes to API to create token and display them (go-gitea#22989) Remove unnecessary and incorrect `find('.menu').toggle()` (go-gitea#22987) Improve issues.LoadProject (go-gitea#22982) Add 1.18.4 changelog (go-gitea#22991) (go-gitea#22995) Fix pull request branch selector visible without clicking Edit (go-gitea#23012) Bump golang.org/x/net from 0.4.0 to 0.7.0 (go-gitea#22980) Fix panic when call api (/repos/{owner}/{repo}/pulls/{index}/files) (go-gitea#22921) only trigger docs build and publish when docs changed (go-gitea#22968) Get rules by id when editing branch protection rule (go-gitea#22932) Fix hidden commit status on multiple checks (go-gitea#22889) Add me to maintainers (go-gitea#22998) Add all units to the units permission list in org team members sidebar (go-gitea#22971) ...
Member
|
Please send backport |
Collaborator
|
I was unable to create a backport for 1.18, please send one manually. 🍵 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that issue pullrequests are loaded before trying to set the self-reference.