Write Gitpod app.ini only once#23192
Merged
Merged
Conversation
delvh
reviewed
Feb 28, 2023
Co-authored-by: delvh <dev.lh@web.de>
delvh
approved these changes
Feb 28, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23192 +/- ##
=======================================
Coverage ? 47.41%
=======================================
Files ? 1140
Lines ? 150988
Branches ? 0
=======================================
Hits ? 71597
Misses ? 70916
Partials ? 8475 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lunny
approved these changes
Feb 28, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 1, 2023
* giteaofficial/main: [skip ci] Updated translations via Crowdin Properly flush unique queues on startup (go-gitea#23154) Use context parameter in services/repository (go-gitea#23186) Pass `--global` when calling `git config --get`, for consistency with `git config --set` (go-gitea#23157) Make `gitea serv` respect git binary home (go-gitea#23138) Write Gitpod `app.ini` only once (go-gitea#23192) Avoid too long names for actions (go-gitea#23162)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the
app.iniwould get overwritten on each workspace start, confusing Gitea. It asked for reinstallation each time. This makes sure the file is written only once by checking it does not exist before creating it.Review without whitespace diff