Skip to content

Add ActionRunStatus component#23259

Merged
lunny merged 9 commits into
go-gitea:mainfrom
yp05327:add-runstatus-component
Mar 6, 2023
Merged

Add ActionRunStatus component#23259
lunny merged 9 commits into
go-gitea:mainfrom
yp05327:add-runstatus-component

Conversation

@yp05327

@yp05327 yp05327 commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Related to: #23212 (comment)

Decrease duplication of SvgIcon when display a run status svg.

@yp05327 yp05327 mentioned this pull request Mar 3, 2023
Merged
@codecov-commenter

codecov-commenter commented Mar 3, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #23259 (e3e2d3a) into main (33e556e) will increase coverage by 0.13%.
The diff coverage is 55.58%.

❗ Current head e3e2d3a differs from pull request most recent head 8feb4a9. Consider uploading reports for the commit 8feb4a9 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main   #23259      +/-   ##
==========================================
+ Coverage   47.44%   47.58%   +0.13%     
==========================================
  Files        1140     1143       +3     
  Lines      150804   151172     +368     
==========================================
+ Hits        71549    71933     +384     
+ Misses      70788    70739      -49     
- Partials     8467     8500      +33
Impacted Files Coverage Δ
cmd/serv.go 2.59% <0.00%> (-0.06%) ⬇️
models/actions/run.go 1.72% <0.00%> (+0.01%) ⬆️
models/actions/run_list.go 0.00% <0.00%> (ø)
models/actions/status.go 22.85% <0.00%> (-1.39%) ⬇️
models/actions/task.go 1.69% <0.00%> (-0.01%) ⬇️
models/auth/oauth2.go 60.52% <ø> (ø)
models/auth/twofactor.go 19.73% <ø> (ø)
models/db/engine.go 44.80% <ø> (ø)
models/unittest/testdb.go 12.92% <0.00%> (ø)
modules/auth/password/hash/pbkdf2.go 69.69% <ø> (ø)
... and 129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 3, 2023
@HesterG

HesterG commented Mar 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

A question about the directory structure, why isn't runstatus.js put into the web_src/js/components folder?

@yp05327

yp05327 commented Mar 3, 2023

Copy link
Copy Markdown
Contributor Author

A question about the directory structure, why isn't runstatus.js put into the web_src/js/components folder?

I didn't notice this problem, as svg.js was in web_src/js.

Then,
I also have a question, why .vue files are in web_src/js/components.
And,
we also have a folder called webcomponents, what is the difference between them.

@wxiaoguang

wxiaoguang commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

we also have a folder called webcomponents, what is the difference between them.

See Add document for webcomponents #23261

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 3, 2023
@delvh delvh added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 3, 2023
@delvh delvh added this to the 1.20.0 milestone Mar 3, 2023
@lunny

lunny commented Mar 3, 2023

Copy link
Copy Markdown
Member

It should be another vue file.

@yp05327 yp05327 changed the title Add runstatus component Add ActionRunStatus component Mar 6, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 6, 2023
@delvh delvh added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 6, 2023
@delvh

delvh commented Mar 6, 2023

Copy link
Copy Markdown
Member

Should we backport this PR?

@wolfogre

wolfogre commented Mar 6, 2023

Copy link
Copy Markdown
Member

Should we backport this PR?

I think yes.

@delvh delvh added the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Mar 6, 2023
@lunny lunny merged commit f0b0f22 into go-gitea:main Mar 6, 2023
@lunny lunny removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 6, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 7, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
9d14e78 
* giteaofficial/main:
  Update documentation for the new YAML label file format  (go-gitea#23020)
  Remove unnecessary space on link (go-gitea#23334)
  Fix incorrect redirect link of delete org project (go-gitea#23327)
  Fix incorrect project links and use symlink icon for org-wide projects (go-gitea#23325)
  Fix PR view misalignment caused by long name file (go-gitea#23321)
  Add ActionRunStatus component (go-gitea#23259)
  Scoped labels: don't require holding alt key to remove (go-gitea#23303)
@GiteaBot

GiteaBot commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

I was unable to create a backport for 1.19, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Mar 9, 2023
@yp05327 yp05327 deleted the add-runstatus-component branch March 13, 2023 01:05
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
@lunny lunny removed the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@wolfogre wolfogre wolfogre approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

8 participants

@yp05327 @codecov-commenter @HesterG @wxiaoguang @lunny @delvh @wolfogre @GiteaBot