Move RepoTransfer from models to models/repo sub package#32506
Merged
Conversation
Contributor
|
Why? What's the benefit? |
Member
Author
I updated the description to explain the reason. |
Contributor
|
Why not totally decouple the repo & org models? Just use them from service packages? |
Member
Author
|
Zettat123
reviewed
Dec 2, 2024
Zettat123
approved these changes
Dec 3, 2024
Member
Author
|
Last call for another review @go-gitea/technical-oversight-committee |
delvh
approved these changes
Dec 17, 2024
delvh
left a comment
Member
There was a problem hiding this comment.
Let's hope there aren't too many places relying on teams having potentially been loaded already (in terms of performance)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RepoTransfernow is at models, but if we want to move it intorepomodel, it will depend onTeam. So this PR also makes repo model depend on org model to make it possible. Just refactor, no code change.DeleteOrganizationfrommodels/organizationto service layerAccessibleTeamReposEnvtomodels/repoRepoTransferfrommodelstomodels/repogetUserTeamIDsandGetUserTeamIDs, MergeGetUserTeamsandgetUserTeams.Team'sRepos []*repo_model.Repositoryto avoid dependency recycle.