Change pprof labels to be prometheus compatible#32865
Merged
Merged
Conversation
Enables scrapping pprof endpoint for continuous profiling
Member
|
Is this a breaking change for those upgraded Gitea instance? |
Contributor
Author
|
It was marked as such in the fork. However the for it to be breaking someone would actively have to scrape the endpoint for (semi-)automated analysis, which I very much doubt anyone is doing (evidence being that no one complained about it). If you consider that a real possibility then yes, it is breaking. |
Member
wxiaoguang
reviewed
Dec 17, 2024
Contributor
No, there are different, do not mix them at the moment. |
wxiaoguang
approved these changes
Dec 17, 2024
lunny
approved these changes
Dec 17, 2024
delvh
approved these changes
Dec 17, 2024
delvh
left a comment
Member
There was a problem hiding this comment.
Let's measure if it is breaking by whether someone complains 😄
Contributor
Actually it breaks nothing ..... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables scrapping pprof endpoint for continuous profiling
Closes: #32854
There's probably room for improvement - for example dropping
graceful_lifecyclecompletely and makingwith-hammerintowith: hammerkey value (or something similar). But I'd wait with that for a proper spec in OTel so there there won't be a need to align to specntimes.Name is compliant with both prometheus regex and OTel recommendation (but not to their semantic conventions):