Skip to content

Move delete deploy keys into service layer#32201

Merged
lunny merged 14 commits into
go-gitea:mainfrom
lunny:lunny/move-delete-deploy-key
Dec 18, 2024
Merged

Move delete deploy keys into service layer#32201
lunny merged 14 commits into
go-gitea:mainfrom
lunny:lunny/move-delete-deploy-key

Conversation

@lunny

@lunny lunny commented Oct 5, 2024

Copy link
Copy Markdown
Member

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Oct 5, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 5, 2024
@lunny lunny requested review from Zettat123 and delvh December 4, 2024 06:07
Comment thread services/asymkey/deploy_key.go Outdated
Comment thread services/asymkey/deploy_key.go Outdated
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 6, 2024
Comment thread models/repo.go
@lunny

lunny commented Dec 17, 2024

Copy link
Copy Markdown
Member Author

Last call for another review @go-gitea/technical-oversight-committee

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 17, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 17, 2024
@lunny lunny added this to the 1.24.0 milestone Dec 18, 2024
@lunny lunny enabled auto-merge (squash) December 18, 2024 03:58
@lunny lunny merged commit f9f62b4 into go-gitea:main Dec 18, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 18, 2024
@lunny lunny deleted the lunny/move-delete-deploy-key branch December 18, 2024 05:25
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants