Skip to content

Fix GetCommitBranchStart bug (#33298)#33421

Merged
silverwind merged 3 commits into
go-gitea:release/v1.23from
GiteaBot:backport-33298-v1.23
Feb 1, 2025
Merged

Fix GetCommitBranchStart bug (#33298)#33421
silverwind merged 3 commits into
go-gitea:release/v1.23from
GiteaBot:backport-33298-v1.23

Conversation

@GiteaBot

@GiteaBot GiteaBot commented Jan 28, 2025

Copy link
Copy Markdown
Collaborator

Backport #33298 by Zettat123

Fix #33265
Fix #33370

This PR also fixes some bugs in TestGitGeneral.

Fix go-gitea#33265
Fix go-gitea#33370

This PR also fixes some bugs in `TestGitGeneral`.
@GiteaBot GiteaBot requested review from lunny and wxiaoguang January 28, 2025 02:59
@GiteaBot GiteaBot added this to the 1.23.2 milestone Jan 28, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 28, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 28, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 28, 2025
@silverwind

Copy link
Copy Markdown
Member

Test failure is related.

@wxiaoguang

Copy link
Copy Markdown
Contributor

@lunny @Zettat123

@lunny

lunny commented Feb 1, 2025

Copy link
Copy Markdown
Member

Maybe #33375 needs to backport to v1.23 to fix the failure test?

@wxiaoguang

Copy link
Copy Markdown
Contributor

Maybe #33375 needs to backport to v1.23 to fix the failure test?

It's too complex to backport. I will try to resolve the failures manually here.

@wxiaoguang

Copy link
Copy Markdown
Contributor

CI passes

@silverwind silverwind merged commit ebac324 into go-gitea:release/v1.23 Feb 1, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators May 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants