Skip to content

Support choose email when creating a commit via web UI#33432

Merged
wxiaoguang merged 2 commits into
go-gitea:mainfrom
wxiaoguang:support-choose-email
Jan 30, 2025
Merged

Support choose email when creating a commit via web UI#33432
wxiaoguang merged 2 commits into
go-gitea:mainfrom
wxiaoguang:support-choose-email

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented Jan 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Initial PR for #24469

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2025
@wxiaoguang

wxiaoguang commented Jan 29, 2025

Copy link
Copy Markdown
Contributor Author

image

This was referenced Jan 29, 2025
Open
Closed
@wxiaoguang wxiaoguang added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Jan 29, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 29, 2025
@wxiaoguang wxiaoguang force-pushed the support-choose-email branch 4 times, most recently from d732ea7 to 54601de Compare January 29, 2025 14:54
@wxiaoguang wxiaoguang force-pushed the support-choose-email branch from 54601de to 8ece4b8 Compare January 29, 2025 14:59
@lunny

lunny commented Jan 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Can you also add the options when

  • upload file page
  • delete file page
  • merging a pull request or creating an auto merge merging task
  • creating a wiki page
  • apply patch page
  • cherry-pick page
  • revert page

@wxiaoguang

wxiaoguang commented Jan 29, 2025

Copy link
Copy Markdown
Contributor Author

Can you also add the options when

Next PRs

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2025
@silverwind silverwind changed the title Support choose email when createing a commit via web UI Support choose email when creating a commit via web UI Jan 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 30, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 30, 2025 01:00
@wxiaoguang wxiaoguang merged commit 256b94e into go-gitea:main Jan 30, 2025
@wxiaoguang wxiaoguang deleted the support-choose-email branch January 30, 2025 09:14
@wxiaoguang wxiaoguang mentioned this pull request Jan 30, 2025
Merged
@wxiaoguang

wxiaoguang commented Jan 30, 2025

Copy link
Copy Markdown
Contributor Author 
* upload file page
* delete file page
* apply patch page
* cherry-pick page
* revert page

-> Support choose email when creating a commit via web UI (more) #33445

wxiaoguang added a commit that referenced this pull request Jan 31, 2025
@wxiaoguang
Support choose email when creating a commit via web UI (more) (#33445)
5a7b42d 
Follow #33432
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @hiifong @GiteaBot