Skip to content

Refactor user & avatar#33433

Merged
lunny merged 1 commit into
go-gitea:mainfrom
wxiaoguang:fix-user-avatar
Jan 29, 2025
Merged

Refactor user & avatar#33433
lunny merged 1 commit into
go-gitea:mainfrom
wxiaoguang:fix-user-avatar

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented Jan 29, 2025

Copy link
Copy Markdown
Contributor
  1. better GetPossibleUserByID logic
  2. fix some function name & comment typos
  3. do not re-generate avatar if one exists

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 29, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Jan 29, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 29, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 29, 2025
@lunny lunny merged commit 4ffc54f into go-gitea:main Jan 29, 2025
@wxiaoguang wxiaoguang deleted the fix-user-avatar branch January 30, 2025 01:00
project-mirrors-bot-tu Bot pushed a commit to project-mirrors/forgejo that referenced this pull request Feb 4, 2025
@earl-warren
feat: do not regenerate an existing random avatar
0817515 
Leave aside the refactoring part of
go-gitea/gitea#33433, keep the improvement.

Also get a test from go-gitea/gitea#31365
while we're at it.

(cherry picked from commit 4ffc54f59a7723eb5aef21955129bdd329ee1d4f)
humaton pushed a commit to fedora-infra/forgejo-deployment-images that referenced this pull request Feb 18, 2025
@earl-warren
feat: do not regenerate an existing random avatar
f6fce27 
Leave aside the refactoring part of
go-gitea/gitea#33433, keep the improvement.

Also get a test from go-gitea/gitea#31365
while we're at it.

(cherry picked from commit 4ffc54f59a7723eb5aef21955129bdd329ee1d4f)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

5 participants

@wxiaoguang @lunny @silverwind @delvh @GiteaBot