Added Description Field for Secrets and Variables #33526
Conversation
|
Is there a standardized length limit for these texts in the project? Maybe we should define constants for these. For now, I've capped them all at 4096 characters |
|
LGTM except #33526 (comment) Screenshots are necessary. |
|
I noticed that the data field also doesn't have a length restriction. I'll add a length constraint to it as well. For this field, I think a limit of 65536 would be appropriate, although we can truncate the display when showing it. const (
VariableDataMaxLength = 65536
VariableDescriptionMaxLength = 4096
)
if utf8.RuneCountInString(data) > VariableDataMaxLength {
data = string([]rune(data)[:VariableDataMaxLength])
}
if utf8.RuneCountInString(description) > VariableDescriptionMaxLength {
description = string([]rune(description)[:VariableDescriptionMaxLength])
}Any other suggestions? |
|
I think the description should be moved under value because it's optional. And it's better to have 2 rows at least. |
Does it refer only to the form, or does it also include the list? Perhaps it would be better to place the description in the list above. |
|
Were all reviews addressed? If so, please resolve them. |
|
All problems have been fixed. |
* giteaofficial/main: [skip ci] Updated translations via Crowdin Optimize Layout Styles of Filelist (go-gitea#33920) [skip ci] Updated translations via Crowdin update go version for devcontainers (go-gitea#33923) Added Description Field for Secrets and Variables (go-gitea#33526) Try to figure out attribute checker problem (go-gitea#33901) Defer captcha script loading (go-gitea#33919) Fix file tree issues (go-gitea#33916) Remove unused or abused styles (go-gitea#33918)
Fixes #33484