Skip to content

Use filepath.Join instead of path.Join for file system file operations#33978

Merged
lunny merged 2 commits into
go-gitea:mainfrom
lunny:lunny/fix_path_join
Mar 24, 2025
Merged

Use filepath.Join instead of path.Join for file system file operations#33978
lunny merged 2 commits into
go-gitea:mainfrom
lunny:lunny/fix_path_join

Conversation

@lunny

@lunny lunny commented Mar 22, 2025

Copy link
Copy Markdown
Member

No description provided.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 22, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 22, 2025
lunny
lunny commented Mar 22, 2025
View reviewed changes
Comment thread modules/git/hook.go
)

// SetUpdateHook writes given content to update hook of the repository.
func SetUpdateHook(repoPath, content string) (err error) {

@lunny lunny Mar 22, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is unused.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 24, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 24, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2025
@lunny lunny merged commit 3fe449c into go-gitea:main Mar 24, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone Mar 24, 2025
@lunny lunny deleted the lunny/fix_path_join branch March 24, 2025 21:50
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 26, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
6d8eaa4 
* giteaofficial/main:
  Enable color output in govulncheck (go-gitea#34012)
  Update Makefile test comments (go-gitea#34013)
  Move duplicated functions (go-gitea#33977)
  Git client will follow 301 but 307 (go-gitea#34005)
  Prepare common tmpl functions in a middleware (go-gitea#33957)
  Update go mod dependencies (go-gitea#33988)
  Fix some migration and repo name problems (go-gitea#33986)
  [skip ci] Updated translations via Crowdin
  Use filepath.Join instead of path.Join for file system file operations (go-gitea#33978)
  Add changelog for 1.23.6 (go-gitea#33975)
  Fix incorrect code search indexer options (go-gitea#33992)
  Auto expand "New PR" form (go-gitea#33971)
  Move ParseBool to optional (go-gitea#33979)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@silverwind silverwind silverwind approved these changes

@lafriks lafriks lafriks approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @silverwind @lafriks @GiteaBot