Refactor repository transfer#33211
Merged
Merged
Conversation
d42ace7 to
45ffedd
Compare
Zettat123
reviewed
Jan 17, 2025
Zettat123
approved these changes
Jan 20, 2025
Contributor
|
It seems that the transfer check don't check the user repo create limitation? |
Member
Author
You are right. This is a bug in the original logic. I will send another PR to fix it. |
yp05327
reviewed
Jan 22, 2025
yp05327
reviewed
Jan 22, 2025
yp05327
reviewed
Jan 22, 2025
Comment on lines
+227
to
+230
| if _, err := user_model.GetUserByID(ctx, newOwner.ID); err != nil { | ||
| return err | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It seems that this is unnecessary. If you got a User pointer, it should come from a GetUserByxxx function, so the user exist check is already done before calling this function, and even if newOwner is nil (although it is impossible), this will cause panic.
Member
Author
There was a problem hiding this comment.
Because this test introduced a non-exist user. So we need to check it here.
yp05327
reviewed
Jan 22, 2025
yp05327
reviewed
Jan 22, 2025
wxiaoguang
reviewed
Jan 27, 2025
wxiaoguang
reviewed
Jan 27, 2025
wxiaoguang
reviewed
Jan 30, 2025
wxiaoguang
approved these changes
Jan 30, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Feb 3, 2025
* giteaofficial/main: (53 commits) [skip ci] Updated licenses and gitignores Correct bot label `vertical-align` (go-gitea#33477) chore: fix some trivial problems and TODOs (go-gitea#33473) Worktime tracking for the organization level (go-gitea#19808) Skip deletion error for action artifacts (go-gitea#33476) Update .changelog file to add performance label group (go-gitea#33472) actions view: move loading of task attributes etc... into own func (go-gitea#31494) [skip ci] Updated translations via Crowdin Update feishu icon (go-gitea#33470) Inclusion of rename organization api (go-gitea#33303) [skip ci] Updated translations via Crowdin Hide/disable unusable UI elements when a repository is archived (go-gitea#33459) Fix SSH LFS memory usage (go-gitea#33455) Revert empty lfs ref name (go-gitea#33454) Update `@github/text-expander-element`, adapt type imports (go-gitea#33449) Support choose email when creating a commit via web UI (more) (go-gitea#33445) Fix issue sidebar dropdown keyboard support (go-gitea#33447) Fix "redirect link" handling (go-gitea#33440) Refactor repository transfer (go-gitea#33211) Enable two more strict options in tsconfig (go-gitea#33438) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both have
RejectTransferandCancelTransferbecause the permission checks are not the same.CancelTransfercan be done by the doer or those who have admin permission to access this repository.RejectTransfercan be done by the receiver user if it's an individual or those who can create repositories if it's an organization.Some tests are wrong, this PR corrects them.