Skip to content

Refactor context RefName and RepoAssignment#33226

Merged
wxiaoguang merged 4 commits into
go-gitea:mainfrom
wxiaoguang:refactor-ref-name
Jan 13, 2025
Merged

Refactor context RefName and RepoAssignment#33226
wxiaoguang merged 4 commits into
go-gitea:mainfrom
wxiaoguang:refactor-ref-name

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented Jan 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

The ctx.Repo.RefName was used to be a "short name", it causes a lot of ambiguity.

This PR does some refactoring and use RefFullName to replace the legacy RefName, and simplify RepoAssignment

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 12, 2025
@wxiaoguang wxiaoguang changed the title fix Refactor context RefName Jan 12, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 12, 2025
Merged
wxiaoguang
wxiaoguang commented Jan 12, 2025
View reviewed changes
Comment thread services/context/repo.go
@wxiaoguang wxiaoguang changed the title Refactor context RefName Refactor context RefName and RepoAssignment Jan 12, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 12, 2025
lunny
lunny approved these changes Jan 12, 2025
View reviewed changes
Comment thread modules/git/repo_archive_test.go Outdated
Comment thread templates/repo/clone_panel.tmpl
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 12, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 13, 2025 00:45
@wxiaoguang wxiaoguang merged commit 8135254 into go-gitea:main Jan 13, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 13, 2025
@wxiaoguang wxiaoguang deleted the refactor-ref-name branch January 13, 2025 01:22
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 14, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
589d5fc 
* giteaofficial/main: (21 commits)
  Support public code/issue access for private repositories (go-gitea#33127)
  Validate that the tag doesn't exist when creating a tag via the web (go-gitea#33241)
  [skip ci] Updated translations via Crowdin
  Switch back to `vue-tsc` (go-gitea#33248)
  Let API create and edit system webhooks, attempt 2 (go-gitea#33180)
  Fix incorrect ref "blob" (go-gitea#33240)
  Refactor RefName (go-gitea#33234)
  Refactor context RefName and RepoAssignment (go-gitea#33226)
  [skip ci] Updated translations via Crowdin
  Fix upload file form (go-gitea#33230)
  Fix mirror bug (go-gitea#33224)
  Remove unused CSS styles and move some styles to proper files (go-gitea#33217)
  Refactor context repository (go-gitea#33202)
  [skip ci] Updated translations via Crowdin
  Fix unpin hint on the pinned pull requests (go-gitea#33207)
  fix(cache): cache test triggered by non memory cache (go-gitea#33220)
  Update README.md (go-gitea#33149)
  Fix editor markdown not incrementing in a numbered list (go-gitea#33187)
  Some small refactors (go-gitea#33144)
  Fix sync fork for consistency (go-gitea#33147)
  ...
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wxiaoguang @lunny @delvh @GiteaBot