Skip to content

Fix 500 error when error occurred in migration page#33256

Merged
wxiaoguang merged 6 commits into
go-gitea:mainfrom
yp05327:fix-500err-migrate
Jan 14, 2025
Merged

Fix 500 error when error occurred in migration page#33256
wxiaoguang merged 6 commits into
go-gitea:mainfrom
yp05327:fix-500err-migrate

Conversation

@yp05327
Copy link
Copy Markdown
Contributor

@yp05327 yp05327 commented Jan 14, 2025

Before:
image

After:
image

Reason:
the template should be repo/migrate/{service type}
But input element service is not in the form.

Related: #33081

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2025
@yp05327
Copy link
Copy Markdown
Contributor Author

yp05327 commented Jan 14, 2025

@yp05327
Copy link
Copy Markdown
Contributor Author

yp05327 commented Jan 14, 2025

I think we can add a test for this.

Copy link
Copy Markdown
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad, thank you for fixing it

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2025
@wxiaoguang wxiaoguang enabled auto-merge (squash) January 14, 2025 06:07
@wxiaoguang wxiaoguang merged commit 3a749fc into go-gitea:main Jan 14, 2025
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 14, 2025
@wxiaoguang wxiaoguang mentioned this pull request Jan 14, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 15, 2025
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Fix some broken route handlers (go-gitea#33268)
  Add a confirm dialog for "sync fork" (go-gitea#33270)
  Fix sidebar milestone link (go-gitea#33269)
  Refactor ref type (go-gitea#33242)
  Fix 500 error when error occurred in migration page (go-gitea#33256)
  Fix missing license when sync mirror (go-gitea#33255)
@yp05327 yp05327 deleted the fix-500err-migrate branch January 17, 2025 05:12
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants