Add anonymous access support for private repositories (backend)#33257
Merged
Conversation
Contributor
Author
|
It seems there is no interest or strong requirement for this feature. Close, until there are enough interests and requirements. |
|
@wxiaoguang I have interest in this feature. I understood #639 with over 100 upvotes is exactly about this, so I think there is overall strong interest in this. #33127 is only half of what #639 was about. |
Contributor
Author
|
Then let's try to bring it into Gitea 1.24 |
2054b7f to
de06c3c
Compare
de06c3c to
095b61e
Compare
095b61e to
4ed6984
Compare
4ed6984 to
ce57b0f
Compare
lunny
reviewed
Mar 28, 2025
lunny
reviewed
Mar 28, 2025
lunny
reviewed
Mar 28, 2025
lunny
reviewed
Mar 28, 2025
| ctx.HTML(http.StatusOK, tplSettingsOptions) | ||
| return | ||
| } | ||
| handleSettingsPostUpdate(ctx) |
Member
There was a problem hiding this comment.
Looks like it's better to move these changes to another PR.
Contributor
Author
There was a problem hiding this comment.
But I have done it together, just don't want to waste time on another PR.
Contributor
Author
There was a problem hiding this comment.
ps: this refactoring is related, to make it easier to make related frontend changes.
If we do not put it here, it will also be in "next PR", otherwise there will be one more PR, too many PRs.
lunny
approved these changes
Mar 28, 2025
hiifong
reviewed
Mar 28, 2025
| format += "\n\tunitsMode[%-v]: %-v" | ||
| args = append(args, key.LogString(), value.LogString()) | ||
| } | ||
| format += "\n\tanonymousAccessMode: %-v" |
Member
There was a problem hiding this comment.
Here we can use the string builder for better performance.
Contributor
Author
There was a problem hiding this comment.
This function won't be called in production. So it doesn't affect performance.
hiifong
approved these changes
Mar 28, 2025
| } | ||
| } | ||
| for t := range perm.anonymousAccessMode { | ||
| if shouldKeep = shouldKeep || u.Type == t; shouldKeep { |
Member
There was a problem hiding this comment.
Here's what I prefer to write: shouldKeep |= u.Type == t, But that's just my personal opinion, and there's nothing wrong with writing it that way
Contributor
Author
There was a problem hiding this comment.
Then it needs 2 lines. Current code only uses one line .......
Contributor
Author
|
Next: Add anonymous access support for private repositories #34051 |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 31, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Add toggleClass function in dom.ts (go-gitea#34063) Add a config option to block "expensive" pages for anonymous users (go-gitea#34024) add additional ReplaceAll in pathsep to cater for different pathsep (go-gitea#34061) [skip ci] Updated translations via Crowdin enable staticcheck QFxxxx rules (go-gitea#34064) update to golangci-lint v2 (go-gitea#34054) Add descriptions for private repo public access settings and improve the UI (go-gitea#34057) Add anonymous access support for private/unlisted repositories (go-gitea#34051) Hide activity contributors, recent commits and code frequrency left tabs if there is no code permission (go-gitea#34053) Update action status badge layout (go-gitea#34018) Add anonymous access support for private repositories (backend) (go-gitea#33257) Simplify emoji rendering (go-gitea#34048) Adjust the layout of the toolbar on the Issues/Projects page (go-gitea#33667) Fix bug on downloading job logs (go-gitea#34041) Fix git client accessing renamed repo (go-gitea#34034) Decouple Batch from git.Repository to simplify usage without requiring the creation of a Repository struct. (go-gitea#34001) fix org repo creation being limited by user limits (go-gitea#34030) Fix the issue with error message logging for the `check-attr` command on Windows OS. (go-gitea#34035) Try to fix check-attr bug (go-gitea#34029)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow #33127
For #8649 and #639
This PR add backend logic and test for "anonymous access", it shares the same logic as "everyone access", so not too much change.
By the way, split
SettingsPostinto small functions to make it easier to make frontend-related changes in the future.Next PR will add frontend support for "anonymous access"
https://github.com/go-gitea/gitea/pull/33257/files?diff=unified&w=1