Skip to content

Allow filtering issues by any assignee#33343

Merged
lunny merged 15 commits into
go-gitea:mainfrom
asvanberg:any-assignee
Mar 21, 2025
Merged

Allow filtering issues by any assignee#33343
lunny merged 15 commits into
go-gitea:mainfrom
asvanberg:any-assignee

Conversation

@asvanberg

@asvanberg asvanberg commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

This is the opposite of the "No assignee" filter, it will match all issues that have at least one assignee.

Before
Before change

After
After change with any filter

@asvanberg
Allow filtering issues by any assignee
6267713 
This is the opposite of the "No assignee" filter.

It will match all issues that have at least one assignee.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 21, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 21, 2025
wxiaoguang
wxiaoguang reviewed Jan 21, 2025
View reviewed changes
Comment thread models/db/search.go Outdated
wxiaoguang
wxiaoguang previously requested changes Jan 21, 2025
View reviewed changes

@wxiaoguang wxiaoguang left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this PR only changes the db search logic.

But there are other search engines, would they go wrong? Correct me if I was wrong.

Details

image

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 21, 2025
@silverwind silverwind self-requested a review January 21, 2025 16:50
@asvanberg

asvanberg commented Jan 21, 2025

Copy link
Copy Markdown
Contributor Author

If I understand correctly, this PR only changes the db search logic.

But there are other search engines, would they go wrong? Correct me if I was wrong.

I searched the code base to find where there was special logic for the db.NoConditionID relating to issue assignees and only found that place and changing it appeared to have solved it.

Looking at modules/indexer/issues/dboptions.go I can see that it converts the -1 (db.NoConditionID) to 0 before passing the search options to the indexers. I could attempt to propagate a magic value down to the indexers search options and handle it in bleve (and the other indexers too I assume) but if you don't want to keep using magic numbers that seems like it would just make a future migration to another datatype require more work?

@wxiaoguang

wxiaoguang commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Without a complete refactoring, I could accept a non-conflicting magic number other than -2 at the moment (see the NonExistingID below), and I think it needs some tests to cover the behavior.

@pull-request-size pull-request-size Bot added size/M and removed size/S labels Feb 23, 2025
@asvanberg asvanberg requested a review from wxiaoguang February 27, 2025 11:55
@wxiaoguang wxiaoguang self-assigned this Feb 27, 2025
@wxiaoguang

wxiaoguang commented Mar 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Will take a look in a few days.

Update: maybe need some more time, I will try to refactor the "assignee" to a meaningful string, to avoid using these strange magic numbers.

@wxiaoguang wxiaoguang changed the title WIP: Allow filtering issues by any assignee Allow filtering issues by any assignee Mar 20, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review March 20, 2025 09:16
@wxiaoguang wxiaoguang removed their assignment Mar 20, 2025
@wxiaoguang wxiaoguang added this to the 1.24.0 milestone Mar 20, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 20, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Mar 20, 2025
@wxiaoguang

wxiaoguang commented Mar 20, 2025

Copy link
Copy Markdown
Contributor

CI passes and ready for review

@asvanberg

asvanberg commented Mar 20, 2025

Copy link
Copy Markdown
Contributor Author

I think we could do this: 330c7e2

I like it. Thanks for picking up the torch and doing the work to get rid of the magic numbers 👍

@wxiaoguang wxiaoguang requested review from lunny and removed request for silverwind March 21, 2025 03:31
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2025
@wxiaoguang wxiaoguang requested a review from silverwind March 21, 2025 03:31
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. labels Mar 21, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 21, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2025
@lunny lunny enabled auto-merge (squash) March 21, 2025 04:00
@lunny lunny merged commit 0da7318 into go-gitea:main Mar 21, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 21, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 24, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
fde02d1 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  Only use prev and next buttons for pagination on user dashboard (go-gitea#33981)
  update jwt and redis packages (go-gitea#33984)
  [skip ci] Updated translations via Crowdin
  Improve oauth2 error handling (go-gitea#33969)
  [skip ci] Updated translations via Crowdin
  Cover `go.mod` and `go.sum` in `.editorconfig` (go-gitea#33960)
  Drop timeout for requests made to the internal hook api (go-gitea#33947)
  Fix file name could not be searched if the file was not a text file when using the Bleve indexer (go-gitea#33959)
  Fix oauth2 auth and UI (go-gitea#33961)
  Allow filtering issues by any assignee (go-gitea#33343)
  Optimize total count of feed when loading activities in user dashboard. (go-gitea#33841)
  Extract code to their own functions for push update (go-gitea#33944)
  Optimize heatmap query (go-gitea#33853)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.24.0

Development

Successfully merging this pull request may close these issues.

5 participants

@asvanberg @wxiaoguang @lunny @silverwind @GiteaBot