Run goimports on the whole project#34
Merged
Merged
Conversation
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
Member
|
Could you please rebase and fix conflicts ? |
Member
|
Please rebase as @strk mentioned. |
bkcsoft
suggested changes
Nov 4, 2016
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
Current coverage is 2.18% (diff: 100%)@@ master #34 diff @@
========================================
Files 31 31
Lines 7508 7508
Methods 0 0
Messages 0 0
Branches 0 0
========================================
Hits 164 164
Misses 7327 7327
Partials 17 17
|
Contributor
Author
|
Recreated the commit with the current |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Feb 7, 2019
7 tasks
pieer
referenced
this pull request
in ikigau/gitea
Oct 27, 2025
…raph Replace all unexplained 'magic numbers' with well-documented constants for better code maintainability and readability. Changes in FishboneGraph.vue: - Added comprehensive constant definitions organized by category: * Demo data generation (RANDOM_MIN, RANDOM_MAX) * Bubble sizing (R_MIN, R_MAX, MAX_DEPTH) * Vertical layout (LEVEL_GAP, stem lengths) * Layout defaults (spacing, offsets, radii) * Collision clearances * Zoom/pan constraints * View reset parameters * Responsive breakpoints and factors * API parameters * Animation durations * SVG layout dimensions * ID generation parameters - Replaced all hardcoded numeric values with named constants - Added inline comments explaining responsive calculation logic - Calculated RADIUS_HEIGHT_RANGE_FACTOR from min/max for clarity Changes in BubbleNode.vue: - Added label layout constants section with documentation: * Font sizing (min/max, scale factors) * Label spacing (padding, gaps) * Text width estimation ratios * Button sizing and positioning - Replaced all magic numbers in label fit calculations - Fixed TypeScript issue with onView accepting both Mouse and Keyboard events Benefits: - All numeric values now have clear, searchable names - Calculations are more readable and self-documenting - Easier to adjust layout behavior by changing constants - Reduces cognitive load when maintaining the code - Makes responsive behavior formulas more transparent
pieer
referenced
this pull request
in ikigau/gitea
Oct 27, 2025
…raph Replace all unexplained 'magic numbers' with well-documented constants for better code maintainability and readability. Changes in FishboneGraph.vue: - Added comprehensive constant definitions organized by category: * Demo data generation (RANDOM_MIN, RANDOM_MAX) * Bubble sizing (R_MIN, R_MAX, MAX_DEPTH) * Vertical layout (LEVEL_GAP, stem lengths) * Layout defaults (spacing, offsets, radii) * Collision clearances * Zoom/pan constraints * View reset parameters * Responsive breakpoints and factors * API parameters * Animation durations * SVG layout dimensions * ID generation parameters - Replaced all hardcoded numeric values with named constants - Added inline comments explaining responsive calculation logic - Calculated RADIUS_HEIGHT_RANGE_FACTOR from min/max for clarity Changes in BubbleNode.vue: - Added label layout constants section with documentation: * Font sizing (min/max, scale factors) * Label spacing (padding, gaps) * Text width estimation ratios * Button sizing and positioning - Replaced all magic numbers in label fit calculations - Fixed TypeScript issue with onView accepting both Mouse and Keyboard events Benefits: - All numeric values now have clear, searchable names - Calculations are more readable and self-documenting - Easier to adjust layout behavior by changing constants - Reduces cognitive load when maintaining the code - Makes responsive behavior formulas more transparent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When opening this repository in my editor, I run goimports automatically. This is what it found.