Fix git graph page#34948
Merged
Merged
Conversation
Contributor
Author
|
Before: DetailsAfter: DetailsAnd there is a regression from "Remove jQuery from the commit graph (except Fomantic) (#30395)", the "hover highlight" stopped working since that time. Actually no one noticed it, no user ever complained, and the "visual feedback" is not obvious. So this PR removes that part of code. |
silverwind
reviewed
Jul 4, 2025
silverwind
reviewed
Jul 4, 2025
silverwind
requested changes
Jul 4, 2025
Signed-off-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Jul 4, 2025
silverwind
left a comment
Member
There was a problem hiding this comment.
Code looks ok, have not tested it.
delvh
reviewed
Jul 4, 2025
Contributor
Author
|
I don't think the Details |
Member
|
Wait, but why are we displaying a title there then in the first place? |
Member
|
I'd remove the tooltip entirely there. |
Member
|
Isn't the title there equally faulty? |
Contributor
Author
They have This PR aims to fix a lot of legacy problems, UI re-design is not in this PR's scope. |
delvh
approved these changes
Jul 4, 2025
wxiaoguang
added a commit
that referenced
this pull request
Jul 4, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 7, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Rerun job only when run is done (go-gitea#34970) Enable gocritic `equalFold` and fix issues (go-gitea#34952) Fixed minor typos in two files #HSFDPMUW (go-gitea#34944) Improve project & label color picker and image scroll (go-gitea#34971) Refactor webhook and fix feishu/lark secret (go-gitea#34961) Improve OAuth2 provider (correct Issuer, respect ENABLED) (go-gitea#34966) Merge index.js (go-gitea#34963) [skip ci] Updated translations via Crowdin Mark old reviews as stale on agit pr updates (go-gitea#34933) Refactor "delete-button" to "link-action" (go-gitea#34962) Refactor frontend unique id & comment (go-gitea#34958) Refactor some trivial problems (go-gitea#34959) Upgrade security public key (go-gitea#34956) Fix git graph page (go-gitea#34948) Update JS dependencies (go-gitea#34951) Refactor head navbar icons (go-gitea#34922) # Conflicts: # templates/base/head_navbar.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Too many bugs, fix together
And fix #34946