fix go version#34299
Conversation
|
@mengzhuo Since the riscv64 patch was contributed by you, maybe you can review this change. I haven't encounter the problem when building in other platform. |
|
FYI: |
57a1b77 to
02c64bc
Compare
go cmd will download and cache a copy of the Go toolchain, but go1.24 is not a valid version since golang/go#57631
|
How the toolchain dependency is managed? For example: if go 1.24.1 has security fixes, then will |
The mod treat |
|
Why should we specify minimum version If anything, I would specify |
|
ci check failed because of security issues in 1.24.{0,1} |
It shouldn't fail with |
|
Ah, it appears https://github.com/actions/setup-go#getting-go-version-from-the-gomod-file
This is very undesired behaviour, but I think it's unlikely they'd want to change it. I guess the best course of action is either not specifying a patch version in go.mod or specify a patch version in |
This method seems to only support setup-go, if I want to run it locally I still need to fix the go version to 1.24.2. |
|
Thanks for your first PR to the project! I think since we will have to bump go.mod regardless, and since actions/setup-go doesn't immediately bump its known latest version we sometimes have to wait on it when go patches are released, so we can skip |
* giteaofficial/main: Fix some dropdown problems on the issue sidebar (go-gitea#34308) [skip ci] Updated translations via Crowdin Fix button alignments (go-gitea#34307) fix go version (go-gitea#34299) Fix the ci build (go-gitea#34309) support the open-icon of folder (go-gitea#34168) Fix wrong review requests when updating the pull request (go-gitea#34286) Enforce two-factor auth (2FA: TOTP or WebAuthn) (go-gitea#34187) actions artifacts api list/download check status upload confirmed (go-gitea#34273)
go cmd will download and cache a copy of the Go toolchain, go1.24 is not a valid version since golang/go#57631.
I am using a fresh installed riscv machine, trying to compile gitea locally. When I try to run the go command, it prompts that the toolchain of version 1.24 not avaliable. After updating go.mod, the download was successful.