Fix inputing review comment will remove reviewer#35591
Merged
Merged
Conversation
Zettat123
approved these changes
Oct 7, 2025
silverwind
approved these changes
Oct 9, 2025
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 10, 2025
silverwind
pushed a commit
that referenced
this pull request
Oct 10, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 13, 2025
* giteaofficial/main: [skip ci] Updated translations via Crowdin Update JS deps, misc tweaks (go-gitea#35643) Bump actions/checkout to v5 (go-gitea#35644) nix flake update (go-gitea#35639) Cleanup ActionRun creation (go-gitea#35624) bump archives&rar dep (go-gitea#35637) Fix merge panic (go-gitea#35606) Bump happy-dom from 19.0.2 to 20.0.0 (go-gitea#35625) Refactor ActionRunJob parsing into a reusable function (go-gitea#35623) Fix code tag style problem and LFS view bug (go-gitea#35628) Support Actions `concurrency` syntax (go-gitea#32751) The status icon of the Action step is consistent with GitHub (go-gitea#35618) Mock external service in hcaptcha TestCaptcha (go-gitea#35604) Fix inputing review comment will remove reviewer (go-gitea#35591) [skip ci] Updated translations via Crowdin Fix diffpatch API endpoint (go-gitea#35610) Print PR-Title into tooltip for actions (go-gitea#35579)
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 14, 2025
Closed
pimpale
added a commit
to hud-evals/gitea
that referenced
this pull request
Dec 23, 2025
Include ReviewTypeComment in the countedReviewTypes slice so that reviewers who only have comment reviews are not removed from the reviewers list. Related: PR go-gitea#35591, Issue go-gitea#34617
pimpale
added a commit
to hud-evals/gitea
that referenced
this pull request
Dec 23, 2025
Tests that reviewers who only have comment reviews are still included in the reviewers list. This test fails on baseline (where ReviewTypeComment is not counted) and passes on golden (with the fix). Related: PR go-gitea#35591, Issue go-gitea#34617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #34617