Skip to content

Fix incorrect pull request counter #35819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Nov 3, 2025
Merged

Fix incorrect pull request counter #35819

merged 19 commits into from
Nov 3, 2025
+218 −21

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 2, 2025 •
edited
Loading

Fix #35781, #27472

The PR will not correct the wrong numbers automatically.

There is a cron task check_repo_stats which will be run when Gitea start or midnight. It will correct the numbers.

@lunny lunny added the type/bug label Nov 2, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 2, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Nov 2, 2025
@lunny lunny added backport/v1.25 backport/v1.24 This PR should be backported to Gitea 1.24 labels Nov 2, 2025
@lunny lunny mentioned this pull request Nov 2, 2025
Closed
yp05327
yp05327 reviewed Nov 3, 2025
View reviewed changes
yp05327
yp05327 reviewed Nov 3, 2025
View reviewed changes
yp05327
yp05327 reviewed Nov 3, 2025
View reviewed changes
yp05327
yp05327 reviewed Nov 3, 2025
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2025
@lunny lunny mentioned this pull request Nov 3, 2025
Merged
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 3, 2025
@lunny lunny enabled auto-merge (squash) November 3, 2025 20:19
@lunny lunny merged commit d9c0f86 into go-gitea:main Nov 3, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 3, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 3, 2025
@lunny lunny deleted the lunny/fix_negative_pr_count branch November 3, 2025 21:33
@GiteaBot
Copy link
Collaborator

GiteaBot commented Nov 3, 2025

I was unable to create a backport for 1.25. @lunny, please send one manually. 🍵

go run ./contrib/backport 35819
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Nov 3, 2025
lunny added a commit to lunny/gitea that referenced this pull request Nov 3, 2025
@lunny
Fix incorrect pull request counter (go-gitea#35819)
c17ba90 
Fix go-gitea#35781, go-gitea#27472

The PR will not correct the wrong numbers automatically.

There is a cron task `check_repo_stats` which will be run when Gitea
start or midnight. It will correct the numbers.
@lunny lunny mentioned this pull request Nov 3, 2025
Merged
@lunny lunny added backport/done All backports for this PR have been created and removed backport/v1.24 This PR should be backported to Gitea 1.24 labels Nov 3, 2025
lunny added a commit that referenced this pull request Nov 4, 2025
@lunny
Fix incorrect pull request counter (#35819) (#35841)
6a55749 
Fix #35781, #27472
Backport #35819 

The PR will not correct the wrong numbers automatically.

There is a cron task `check_repo_stats` which will be run when Gitea
start or midnight. It will correct the numbers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yp05327 yp05327 yp05327 left review comments

@wolfogre wolfogre wolfogre approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

Pull requests show negative number -1 after merge

5 participants

@lunny @GiteaBot @wolfogre @Zettat123 @yp05327