Skip to content

Add Notifications section in User Settings#35008

Merged
wxiaoguang merged 11 commits into
mainfrom
unknown repository
Jul 11, 2025
Merged

Add Notifications section in User Settings#35008
wxiaoguang merged 11 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Jul 9, 2025

Copy link
Copy Markdown

image

Related: #34982

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2025
@silverwind

Copy link
Copy Markdown
Member

I see where this is coming from as GitHub also has such a section. I wonder if we have more stuff to put into it than this single option.

@ghost

ghost commented Jul 9, 2025

Copy link
Copy Markdown
Author

@silverwind Yes, I plan to put Actions email settings in it.

@lunny lunny added this to the 1.25.0 milestone Jul 9, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2025
@xuedi

xuedi commented Jul 10, 2025

Copy link
Copy Markdown

at work i get 4000+ emails daily, i never look into any of them, i just use the filters "review requested" and "Created by you" ... Its killing my postbox, and if i unfollow i don't get the bubble notification ...

Thanks a lot for this PR !!

@ghost

ghost commented Jul 10, 2025

Copy link
Copy Markdown
Author

@xuedi @lunny My current plan is:

  1. Add the new Notification section
  2. Merge it to Send email on Workflow Run Success/Failure #34982
  3. Add Actions email settings, add new table and migration.

@ghost

ghost commented Jul 10, 2025

Copy link
Copy Markdown
Author

@xuedi @lunny Presumably in future PRs, could drop current notification setting constants and create a set of fine-grained notification settings similar to GitHub's. Since lots focus on Issues, Pull Requests and Releases, probably won't be a difficult task. Can start from EmailNotificationsPreference reference in code and rewrite stuff.

@lunny

lunny commented Jul 10, 2025

Copy link
Copy Markdown
Member

Thank you. I also think this PR should be merged first.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 10, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 10, 2025
Comment thread routers/web/user/setting/notifications.go Outdated
Comment thread routers/web/user/setting/notifications.go Outdated
Comment thread routers/web/web.go Outdated
NorthRealm and others added 2 commits July 11, 2025 00:53
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Signed-off-by: NorthRealm <155140859+NorthRealm@users.noreply.github.com>
@wxiaoguang wxiaoguang removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jul 10, 2025
@wxiaoguang wxiaoguang merged commit 56eccb4 into go-gitea:main Jul 11, 2025
26 checks passed
@ghost ghost deleted the patch7 branch July 11, 2025 03:18
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 14, 2025
* giteaofficial/main:
  Refactor view issue & comment list styles (go-gitea#35061)
  Fix user's sign email check (go-gitea#35045)
  [skip ci] Updated translations via Crowdin
  Fix incorrect comment diff hunk parsing, fix github asset ID nil panic (go-gitea#35046)
  Add Notifications section in User Settings (go-gitea#35008)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants