Make security-check informational only#36681
Merged
Merged
Conversation
lafriks
approved these changes
Feb 20, 2026
techknowlogick
approved these changes
Feb 20, 2026
chhe
pushed a commit
to chhe/act_runner
that referenced
this pull request
Feb 22, 2026
## Summary - Replace old `.golangci.yml` (v1 format) with v2 format, aligned with gitea's lint config - Add `lint-go`, `lint-go-fix`, and `lint` Makefile targets using golangci-lint v2.10.1 - Replace `make vet` with `make lint` in CI workflow (lint includes vet) - Fix all 35 lint issues: modernize (maps.Copy, range over int, any), perfsprint (errors.New), unparam (remove unused parameters), revive (var naming), staticcheck, forbidigo exclusion for cmd/ - Make `security-check` non-fatal (apply go-gitea/gitea#36681) - Remove dead gocritic exclusion rules (commentFormatting, exitAfterDefer) - Remove dead linter exclusions and disabled checks (singleCaseSwitch, ST1003, QF1001, QF1006, QF1008, testifylint go-require/require-error, test file exclusions for dupl/errcheck/staticcheck/unparam) ## Test plan - [x] `golangci-lint run` passes - [x] `go build ./...` passes - [x] `go test ./...` passes --------- Co-authored-by: ChristopherHX <christopher.homberger@web.de> Co-authored-by: Christopher Homberger <christopher.homberger@web.de> Reviewed-on: https://gitea.com/gitea/act_runner/pulls/803 Reviewed-by: ChristopherHX <christopherhx@noreply.gitea.com>
Member
Author
|
Still a problem on 1.25 branch, flagged this for backport. |
Collaborator
|
I was unable to create a backport for 1.25. @silverwind, please send one manually. 🍵 |
Copilot AI
added a commit
that referenced
this pull request
Mar 6, 2026
Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>
lunny
pushed a commit
that referenced
this pull request
Mar 6, 2026
Backport #36681 `security-check` (govulncheck) was failing CI on all PRs whenever vulnerabilities existed in dependencies. Since https://github.com/go-gitea/gitea/security/dependabot already surfaces this information, the check should be informational only. - **`Makefile`**: Append `|| true` to the `security-check` target so govulncheck output is preserved but non-zero exits no longer break CI. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
security-checknot break the build which is a major inconvenience as it breaks CI on all PRs.https://github.com/go-gitea/gitea/security/dependabot already provides a clean overview of outstanding security issues in dependencies and I'm using it all the time to find and update vulnerable dependencies.