Skip to content

Add class "list-header-filters" to the div for projects#36889

Merged
techknowlogick merged 4 commits into
go-gitea:mainfrom
tyroneyeh:mian_36886
Mar 24, 2026
Merged

Add class "list-header-filters" to the div for projects#36889
techknowlogick merged 4 commits into
go-gitea:mainfrom
tyroneyeh:mian_36886

Conversation

@tyroneyeh

@tyroneyeh tyroneyeh commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

closes #36886

Before:
image

After:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 12, 2026
@lunny lunny requested a review from Copilot March 21, 2026 18:42
Copilot AI reviewed Mar 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses #36886 by aligning the Projects view page header filter container with existing “list header” filter styling, so label/assignee/milestone dropdowns get the constrained height/scroll behavior already used elsewhere.

Changes:

  • Add the list-header-filters class to the filter menu container in the project view header.
  • Reuse existing CSS behavior tied to .list-header-filters to prevent dropdown menus from expanding the page height.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@silverwind

silverwind commented Mar 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I don't quite understand how this could work, given that a number of other similar menus don't have that class and I see nothing in the CSS that says "limit height", but I guess it's still an improvement.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 23, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 23, 2026
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Mar 23, 2026
@lunny lunny added this to the 1.26.0 milestone Mar 23, 2026
@techknowlogick techknowlogick enabled auto-merge (squash) March 24, 2026 16:50
@techknowlogick techknowlogick added type/bug reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 24, 2026
@techknowlogick techknowlogick merged commit c96cc70 into go-gitea:main Mar 24, 2026
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 24, 2026
@tyroneyeh tyroneyeh deleted the mian_36886 branch March 24, 2026 19:43
@wxiaoguang

wxiaoguang commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

I don't quite understand how this could work, given that a number of other similar menus don't have that class and I see nothing in the CSS that says "limit height", but I guess it's still an improvement.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@lunny lunny lunny approved these changes

@silverwind silverwind silverwind approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

UI: Project labels/assignee dropdowns expand page height instead of scrolling internally

7 participants

@tyroneyeh @silverwind @wxiaoguang @lunny @techknowlogick @GiteaBot