Require additional user confirmation for making repo private#36959
Merged
techknowlogick merged 12 commits intoMar 24, 2026
Merged
Require additional user confirmation for making repo private#36959techknowlogick merged 12 commits into
techknowlogick merged 12 commits into
Conversation
bircni
reviewed
Mar 23, 2026
wxiaoguang
reviewed
Mar 23, 2026
wxiaoguang
reviewed
Mar 23, 2026
wxiaoguang
reviewed
Mar 23, 2026
| } | ||
|
|
||
| func TestRepositoryVisibilityChangeToPublicDoesNotRequireName(t *testing.T) { | ||
| onGiteaRun(t, func(t *testing.T, u *url.URL) { |
Contributor
There was a problem hiding this comment.
Why it needs onGiteaRun? Why these 2 tests can't be done in one test (one preparation)?
Contributor
There was a problem hiding this comment.
This review was marked as resolved, but not addressed.
I removed the onGiteaRun in new commits and the tests still run correctly.
wxiaoguang
reviewed
Mar 23, 2026
Member
|
Do you have an UI example? |
added 2 commits
March 23, 2026 14:31
Member
Author
|
Here is a screenshot of what the modal looks like, prompting the user to type in fully username/repo: |
lunny
approved these changes
Mar 23, 2026
wxiaoguang
reviewed
Mar 24, 2026
Signed-off-by: techknowlogick <matti@mdranta.net>
wxiaoguang
reviewed
Mar 24, 2026
Contributor
Old UI on main branchThis PR's old UINew UI |
wxiaoguang
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To align with how GitHub requires additional explicit user interaction to make a repo private, including informing them of implications on what happens if they do.