Skip to content

Fix edit user email bug in API (#36068)#36081

Merged
silverwind merged 2 commits into
go-gitea:release/v1.25from
GiteaBot:backport-36068-v1.25
Dec 4, 2025
Merged

Fix edit user email bug in API (#36068)#36081
silverwind merged 2 commits into
go-gitea:release/v1.25from
GiteaBot:backport-36068-v1.25

Conversation

@GiteaBot
Copy link
Copy Markdown
Collaborator

@GiteaBot GiteaBot commented Dec 4, 2025

Backport #36068 by @lunny

Follow #36058 for API edit user bug when editing email.

  • The Admin Edit User API includes a breaking change. Previously, when updating a user with an email from an unallowed domain, the request would succeed but return a warning in the response headers. Now, the request will fail and return an error in the response body instead.
  • Removed AdminAddOrSetPrimaryEmailAddress because it will not be used any where.

Fix #36058 (comment)

Follow go-gitea#36058 for API edit user bug when editing email.

- The Admin Edit User API includes a breaking change. Previously, when
updating a user with an email from an unallowed domain, the request
would succeed but return a warning in the response headers. Now, the
request will fail and return an error in the response body instead.
- Removed `AdminAddOrSetPrimaryEmailAddress` because it will not be used
any where.

Fix go-gitea#36058 (comment)

---------

Co-authored-by: Giteabot <teabot@gitea.io>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2025
@GiteaBot GiteaBot added this to the 1.25.3 milestone Dec 4, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2025
@silverwind silverwind enabled auto-merge (squash) December 4, 2025 15:53
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2025
@silverwind silverwind merged commit 52902d4 into go-gitea:release/v1.25 Dec 4, 2025
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2025
@xnox xnox mentioned this pull request Dec 7, 2025
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants