Skip to content

chore: Conventional adjustments#37677

Merged
bircni merged 4 commits into
go-gitea:mainfrom
bircni:conventional-adjustments
May 17, 2026
Merged

chore: Conventional adjustments#37677
bircni merged 4 commits into
go-gitea:mainfrom
bircni:conventional-adjustments

Conversation

@bircni

@bircni bircni commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Add enhancement to possible tags

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 12, 2026
@bircni bircni marked this pull request as ready for review May 12, 2026 15:44
@bircni bircni marked this pull request as draft May 12, 2026 15:46
@bircni bircni added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 12, 2026
@bircni bircni mentioned this pull request May 12, 2026
Closed
@silverwind

silverwind commented May 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Note: special security care must be taken on pull-labeler, it runs at pull_request_target which means it has elevated privileges. Numerous repos get hacked via this target through improper handling of untrusted input.

@bircni

bircni commented May 13, 2026

Copy link
Copy Markdown
Member Author

Note: special security care must be taken on pull-labeler, it runs at pull_request_target which means it has elevated privileges. Numerous repos get hacked via this target through improper handling of untrusted input.

any idea how?

@TheFox0x7

TheFox0x7 commented May 13, 2026

Copy link
Copy Markdown
Contributor

Generally this should be safe as it doesn't checkout the PR code and it's not doing anything major with the input. Only the title would be of concern potentially as it's attacker controlled.
@ChristopherHX could probably say more on that.

@bircni bircni requested review from ChristopherHX and removed request for ChristopherHX May 16, 2026 06:38
@bircni bircni force-pushed the conventional-adjustments branch from 47c6109 to 429e44e Compare May 17, 2026 14:17
@bircni bircni marked this pull request as ready for review May 17, 2026 14:17
@bircni

bircni commented May 17, 2026

Copy link
Copy Markdown
Member Author

I suggest we move the labeling to https://github.com/go-gitea/giteabot

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 17, 2026
@bircni bircni requested a review from wxiaoguang May 17, 2026 15:34
wxiaoguang
wxiaoguang reviewed May 17, 2026
View reviewed changes

@wxiaoguang wxiaoguang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enhancement is much longer than others like feat, perf

@bircni

bircni commented May 17, 2026

Copy link
Copy Markdown
Member Author

enhancement is much longer than others like feat, perf

what do you suggest then?

@wxiaoguang

wxiaoguang commented May 17, 2026

Copy link
Copy Markdown
Contributor

AI suggested to use "enhance" or "improve"

bircni
bircni commented May 17, 2026
View reviewed changes
Comment thread tools/lint-pr-title.js Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
bircni added 2 commits May 17, 2026 18:43
@bircni
Apply suggestions from code review
e8d6864 
Co-authored-by: Nicolas <bircni@icloud.com>
Signed-off-by: Nicolas <bircni@icloud.com>
@bircni
Merge branch 'main' into conventional-adjustments
b11fe03
@bircni

bircni commented May 17, 2026

Copy link
Copy Markdown
Member Author

AI suggested to use "enhance" or "improve"

fixed

wxiaoguang
wxiaoguang approved these changes May 17, 2026
View reviewed changes

@wxiaoguang wxiaoguang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new question for the future: whether or how to make the commit title work with labels (not in this PR's scope)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2026
@bircni

bircni commented May 17, 2026

Copy link
Copy Markdown
Member Author

A new question for the future: whether or how to make the commit title work with labels (not in this PR's scope)

What do you mean exactly?

@bircni bircni added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 17, 2026
@bircni bircni enabled auto-merge (squash) May 17, 2026 20:16
@wxiaoguang

wxiaoguang commented May 17, 2026

Copy link
Copy Markdown
Contributor

A new question for the future: whether or how to make the commit title work with labels (not in this PR's scope)

What do you mean exactly?

Should the commit title prefix affect the PR labels? How to make them work together clearly?

@bircni

bircni commented May 17, 2026

Copy link
Copy Markdown
Member Author

A new question for the future: whether or how to make the commit title work with labels (not in this PR's scope)

What do you mean exactly?

Should the commit title prefix affect the PR labels? How to make them work together clearly?

sure the auto labeling gets easy then - breaking changes are easy to see etc

@bircni bircni merged commit 0dd8429 into go-gitea:main May 17, 2026
21 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone May 17, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 17, 2026
silverwind added a commit to silverwind/gitea that referenced this pull request May 17, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into lint-shell
56767d4 
* origin/main:
  fix: Allow direct commits for unprotected files with push restrictions (go-gitea#37657)
  chore: Conventional adjustments (go-gitea#37677)
  chore(db): introduce db.Session and db.EngineMigration interfaces (go-gitea#37746)
  fix(migrations): preserve unique constraints in v334 sync (go-gitea#37743)
  feat(web): also display PR counts in repo list (go-gitea#37739)
silverwind added a commit to silverwind/gitea that referenced this pull request May 18, 2026
@silverwind
Merge remote-tracking branch 'origin/main' into ci-cache-improvements
751acd4 
* origin/main: (39 commits)
  fix: Add missed token scope checking (go-gitea#37735)
  chore: Use giteabot instead of backporter (go-gitea#37422)
  fix: Allow direct commits for unprotected files with push restrictions (go-gitea#37657)
  chore: Conventional adjustments (go-gitea#37677)
  chore(db): introduce db.Session and db.EngineMigration interfaces (go-gitea#37746)
  fix(migrations): preserve unique constraints in v334 sync (go-gitea#37743)
  feat(web): also display PR counts in repo list (go-gitea#37739)
  feat: execute post run cleanup when workflow is cancelled (go-gitea#37275)
  fix(actions): wrong assumption that run id always >= job id (go-gitea#37737)
  fix(icon): use repo-forked icon to display forks count (go-gitea#37731)
  fix(oauth): strengthen PKCE validation and refresh token replay protection (go-gitea#37706)
  fix(web): enforce token scopes on raw, media, and attachment downloads (go-gitea#37698)
  feat: Add bypass allowlist for branch protection (go-gitea#36514)
  refactor(glob): use strings.Builder for regexp compilation (go-gitea#37730)
  feat(oauth): Support AWS Cognito OAuth2 provider (go-gitea#37607)
  feat: Add default PR branch update style setting (go-gitea#37410)
  refactor: move `workflowpattern` into `modules/actions` (go-gitea#37717)
  ci: add `zizmor` to `lint-actions` (go-gitea#37720)
  chore(doctor): remove four obsolete doctor check implementations (go-gitea#37728)
  chore(renovate): enable dockerfile manager (go-gitea#37719)
  ...

# Conflicts:
#	modules/globallock/locker_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.

Projects

None yet

Milestone

1.27.0

Development

Successfully merging this pull request may close these issues.

6 participants

@bircni @silverwind @TheFox0x7 @wxiaoguang @lunny @GiteaBot