Skip to content

chore: make DefaultTitleSource default to auto to match GitHub#37767

Merged
lunny merged 2 commits into
go-gitea:mainfrom
wxiaoguang:fix-DefaultTitleSource
May 18, 2026
Merged

chore: make DefaultTitleSource default to auto to match GitHub#37767
lunny merged 2 commits into
go-gitea:mainfrom
wxiaoguang:fix-DefaultTitleSource

Conversation

@wxiaoguang

@wxiaoguang wxiaoguang commented May 18, 2026

Copy link
Copy Markdown
Contributor

It is a changed (breaking) behavior introduced in 1.26, no need to have such a breaking change.

For 1.26: #37766

@wxiaoguang wxiaoguang changed the title Make DefaultTitleSource default to auto to match GitHub chore: make DefaultTitleSource default to auto to match GitHub May 18, 2026
@wxiaoguang wxiaoguang added backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.26 This PR should be backported to Gitea 1.26 labels May 18, 2026
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2026
@github-actions github-actions Bot added the docs-update-needed The document needs to be updated synchronously label May 18, 2026
@bircni

bircni commented May 18, 2026

Copy link
Copy Markdown
Member

If it is Breaking again, then it is a fix!: not a chore

@wxiaoguang wxiaoguang changed the title chore: make DefaultTitleSource default to auto to match GitHub fix!: make DefaultTitleSource default to auto to match GitHub May 18, 2026
@wxiaoguang wxiaoguang changed the title fix!: make DefaultTitleSource default to auto to match GitHub chore: make DefaultTitleSource default to auto to match GitHub May 18, 2026
@wxiaoguang

Copy link
Copy Markdown
Contributor Author

If it is Breaking again, then it is a fix!: not a chore

It is a chore here, there is no breaking change after 1.26.2

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2026
@lunny lunny merged commit ff1b8b2 into go-gitea:main May 18, 2026
24 of 25 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone May 18, 2026
@wxiaoguang wxiaoguang deleted the fix-DefaultTitleSource branch May 18, 2026 22:52
silverwind added a commit to silverwind/gitea that referenced this pull request May 19, 2026
* origin/main: (104 commits)
  fix(deps): update module github.com/go-git/go-git/v5 to v5.19.1 [security] (go-gitea#37786)
  fix(pull): handle empty pull request files view to allow reviews (go-gitea#37783)
  fix(markup): make RenderString never fail (go-gitea#37779)
  fix(markup): wrap indented code blocks for the code-copy button (go-gitea#37748)
  fix(permissions): Fix reading permission (go-gitea#37769)
  fix: add natural sort to sortTreeViewNodes (go-gitea#37772)
  fix: package creation unique conflict (go-gitea#37774)
  fix(deps): update npm dependencies (go-gitea#37768)
  fix(deps): update module gitlab.com/gitlab-org/api/client-go/v2 to v2.26.0 (go-gitea#37771)
  ci: split giteabot workflow (go-gitea#37770)
  [skip ci] Updated translations via Crowdin
  fix: Unify public-only token filtering in API queries and repo access checks (go-gitea#37118)
  fix(deps): update module google.golang.org/grpc to v1.81.1 (go-gitea#37762)
  chore: make DefaultTitleSource default to auto to match GitHub (go-gitea#37767)
  ci: fix cache-related issues (go-gitea#37761)
  chore: fix tests (go-gitea#37760)
  refactor(waitgroup): replace Add/Done goroutines with WaitGroup.Go (go-gitea#37764)
  fix(deps): update go dependencies (go-gitea#37752)
  chore(deps): update action dependencies (go-gitea#37751)
  fix(deps): update module github.com/google/go-github/v85 to v86 (go-gitea#37754)
  ...

# Conflicts:
#	.github/workflows/pull-db-tests.yml
#	modules/storage/s3_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.26 This PR should be backported to Gitea 1.26 docs-update-needed The document needs to be updated synchronously lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants