Skip to content

Fix bug when accessing user badges#37321

Merged
silverwind merged 4 commits into
go-gitea:mainfrom
lunny:lunny/fix_badge
Apr 21, 2026
Merged

Fix bug when accessing user badges#37321
silverwind merged 4 commits into
go-gitea:mainfrom
lunny:lunny/fix_badge

Conversation

@lunny
Copy link
Copy Markdown
Member

@lunny lunny commented Apr 20, 2026

Fix #37302

@lunny lunny added type/bug backport/v1.26 This PR should be backported to Gitea 1.26 labels Apr 20, 2026
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2026
@bircni bircni self-requested a review April 20, 2026 17:37
@wxiaoguang
Copy link
Copy Markdown
Contributor

The test is not right, it tests nothing.

You should know: unit test doesn't run on pgsql.

@wxiaoguang wxiaoguang marked this pull request as draft April 20, 2026 17:43
@lunny
Copy link
Copy Markdown
Member Author

lunny commented Apr 20, 2026

The test is not right, it tests nothing.

You should know: unit test doesn't run on pgsql.

Ah, yes — maybe we should run unit tests against multiple databases, but keep integration tests limited to PostgreSQL.

@lunny
Copy link
Copy Markdown
Member Author

lunny commented Apr 20, 2026

The test is not right, it tests nothing.

You should know: unit test doesn't run on pgsql.

Removed the unused test but it seems it's unnecessary to have a new integration test for it.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 21, 2026
@wxiaoguang wxiaoguang marked this pull request as ready for review April 21, 2026 00:29
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2026
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2026
@silverwind silverwind enabled auto-merge (squash) April 21, 2026 00:43
@silverwind silverwind merged commit 12733d3 into go-gitea:main Apr 21, 2026
26 checks passed
@GiteaBot GiteaBot added this to the 1.27.0 milestone Apr 21, 2026
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2026
@wxiaoguang wxiaoguang deleted the lunny/fix_badge branch April 21, 2026 01:22
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Apr 21, 2026
lunny added a commit that referenced this pull request Apr 21, 2026
Backport #37321 by @lunny

Fix #37302

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
silverwind added a commit to 6543-forks/gitea that referenced this pull request Apr 21, 2026
…n-better

* origin/main: (645 commits)
  When the requested arch rpm is missing fall back to noarch (go-gitea#37236)
  Fix `relative-time` error and improve global error handler (go-gitea#37241)
  Enhance styling in actions page (go-gitea#37323)
  fix(oauth): Error on auth sources with spaces (go-gitea#37327)
  Fix actions concurrency groups cross-branch leak (go-gitea#37311)
  Fix bug when accessing user badges (go-gitea#37321)
  Fix AppFullLink (go-gitea#37325)
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  Use updated yaml fields for snapcraft (go-gitea#37318)
  Remove dead code identified by `deadcode` tool (go-gitea#37271)
  Enable strict TypeScript, add `errorMessage` helper (go-gitea#37292)
  Fix vite manifest update masking build errors (go-gitea#37279)
  bump snapcraft base (go-gitea#37301)
  Add WebKit to e2e test matrix (go-gitea#37298)
  Don't add useless labels which will bother changelog generation (go-gitea#37267)
  Fix Repository transferring page (go-gitea#37277)
  ...

# Conflicts:
#	options/locale/locale_en-US.ini
#	templates/package/content/debian.tmpl
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 22, 2026
* main: (25 commits)
  Add URL to `Learn more about blocking a user` (go-gitea#37355)
  fix: use TriggerEvent instead of Event in workflow runs API response for scheduled runs (go-gitea#37288)
  Add event.schedule context for schedule actions task (go-gitea#37320)
  Fix typos (go-gitea#37346)
  Fix an issue where changing an organization’s visibility caused problems when users had forked its repositories. (go-gitea#37324)
  Fail vite build on rolldown warnings via NODE_ENV=test (go-gitea#37270)
  Use modern "git update-index --cacheinfo" syntax to support more file names (go-gitea#37338)
  Fix URL related escaping for oauth2 (go-gitea#37334)
  When the requested arch rpm is missing fall back to noarch (go-gitea#37236)
  Fix `relative-time` error and improve global error handler (go-gitea#37241)
  Enhance styling in actions page (go-gitea#37323)
  fix(oauth): Error on auth sources with spaces (go-gitea#37327)
  Fix actions concurrency groups cross-branch leak (go-gitea#37311)
  Fix bug when accessing user badges (go-gitea#37321)
  Fix AppFullLink (go-gitea#37325)
  Update go js dependencies (go-gitea#37312)
  Update GitHub Actions to latest major versions (go-gitea#37313)
  Revert "Add WebKit to e2e test matrix (go-gitea#37298)" (go-gitea#37315)
  Add `form-fetch-action` to some forms, fix "fetch action" resp bug (go-gitea#37305)
  Move heatmap to first-party code (go-gitea#37262)
  ...
yamz8 pushed a commit to kerneliushq/kernelius-forge-cli that referenced this pull request May 11, 2026
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [docker.gitea.com/gitea](https://github.com/go-gitea/gitea) | service | patch | `1.26.0` → `1.26.1` |

---

### Release Notes

<details>
<summary>go-gitea/gitea (docker.gitea.com/gitea)</summary>

### [`v1.26.1`](https://github.com/go-gitea/gitea/releases/tag/v1.26.1)

[Compare Source](go-gitea/gitea@v1.26.0...v1.26.1)

- BUGFIXES   \* Add event.schedule context for schedule actions task ([#&#8203;37320](go-gitea/gitea#37320)) ([#&#8203;37348](go-gitea/gitea#37348))   \* Fix an issue where changing an organization's visibility caused problems when users had forked its repositories. ([#&#8203;37324](go-gitea/gitea#37324)) ([#&#8203;37344](go-gitea/gitea#37344))   \* Use modern "git update-index --cacheinfo" syntax to support more file names ([#&#8203;37338](go-gitea/gitea#37338)) ([#&#8203;37343](go-gitea/gitea#37343))   \* Fix URL related escaping for oauth2 ([#&#8203;37334](go-gitea/gitea#37334)) ([#&#8203;37340](go-gitea/gitea#37340))   \* When the requested arch rpm is missing fall back to noarch ([#&#8203;37236](go-gitea/gitea#37236)) ([#&#8203;37339](go-gitea/gitea#37339))   \* Fix actions concurrency groups cross-branch leak ([#&#8203;37311](go-gitea/gitea#37311)) ([#&#8203;37331](go-gitea/gitea#37331))   \* Fix bug when accessing user badges ([#&#8203;37321](go-gitea/gitea#37321)) ([#&#8203;37329](go-gitea/gitea#37329))   \* Fix AppFullLink ([#&#8203;37325](go-gitea/gitea#37325)) ([#&#8203;37328](go-gitea/gitea#37328))   \* Fix container auth for public instance ([#&#8203;37290](go-gitea/gitea#37290)) ([#&#8203;37294](go-gitea/gitea#37294))   \* Enhance GetActionWorkflow to support fallback references ([#&#8203;37189](go-gitea/gitea#37189)) ([#&#8203;37283](go-gitea/gitea#37283))   \* Fix vite manifest update masking build errors ([#&#8203;37279](go-gitea/gitea#37279)) ([#&#8203;37310](go-gitea/gitea#37310))   \* Fix Mermaid diagrams failing when node labels contain line breaks ([#&#8203;37296](go-gitea/gitea#37296)) ([#&#8203;37299](go-gitea/gitea#37299))   \* Use TriggerEvent instead of Event in workflow runs API response for scheduled runs ([#&#8203;37288](go-gitea/gitea#37288)) [#&#8203;37360](go-gitea/gitea#37360)   \* Add URL to Learn more about blocking a user. ([#&#8203;37355](go-gitea/gitea#37355)) [#&#8203;37367](go-gitea/gitea#37367)   \* Fix button layout shift when collapsing file tree in editor ([#&#8203;37363](go-gitea/gitea#37363)) [#&#8203;37375](go-gitea/gitea#37375)   \* Fix org team assignee/reviewer lookups for team member permissions ([#&#8203;37365](go-gitea/gitea#37365)) [#&#8203;37391](go-gitea/gitea#37391)   \* Fix repo init README EOL ([#&#8203;37388](go-gitea/gitea#37388)) [#&#8203;37399](go-gitea/gitea#37399)   \* Fix: dump with default zip type produces uncompressed zip ([#&#8203;37401](https://github.com/go-gitea/gitea/issues/37401))[#&#8203;37402](https://github.com/go-gitea/gitea/issues/37402)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNDAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE0MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://gitea.com/gitea/tea/pulls/968
Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.26 This PR should be backported to Gitea 1.26 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP 500 when accessing user badges

5 participants