Skip to content

fix commit page showing status for current default branch (#5649)#5650

Merged
lafriks merged 1 commit into
go-gitea:masterfrom
apricote:fix-commit-page-shows-master-status
Jan 6, 2019
Merged

fix commit page showing status for current default branch (#5649)#5650
lafriks merged 1 commit into
go-gitea:masterfrom
apricote:fix-commit-page-shows-master-status

Conversation

@apricote

@apricote apricote commented Jan 6, 2019

Copy link
Copy Markdown
Contributor

Fixes #5649.

Instead of showing the status for the current commit in the default branch (ctx.Repo.Commit.ID) show status for selected commit (commitID).

Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #5650 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5650      +/-   ##
=========================================
- Coverage   37.81%   37.8%   -0.01%     
=========================================
  Files         322     322              
  Lines       47489   47489              
=========================================
- Hits        17957   17955       -2     
- Misses      26943   26946       +3     
+ Partials     2589    2588       -1
Impacted Files Coverage Δ
routers/repo/commit.go 16.26% <0%> (ø) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0236856...2627273. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 6, 2019
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Jan 6, 2019
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 6, 2019
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 6, 2019
@lafriks lafriks added this to the 1.8.0 milestone Jan 6, 2019
@lafriks lafriks merged commit 97dafdc into go-gitea:master Jan 6, 2019
@lafriks

lafriks commented Jan 6, 2019

Copy link
Copy Markdown
Member

Please backport to release/1.7 branch

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Jan 6, 2019
jonasfranz pushed a commit that referenced this pull request Jan 6, 2019
)

Signed-off-by: Julian Tölle <julian.toelle97@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
project-mirrors-bot-tu Bot pushed a commit to project-mirrors/forgejo-as-gitea-fork that referenced this pull request Jan 23, 2025
- When a truncated comment is detected in the RSS/Atom feeds, fetch the
comment from the database and use the original content.
- Added integration test.
- Resolves go-gitea#5650

(cherry picked from commit f4a7132)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit Diff page always shows status for current default branch

7 participants