Prevent nil dereference in mailIssueCommentToParticipants (#5891, #5895)#5894
Merged
zeripath merged 2 commits intoJan 29, 2019
Merged
Conversation
…itea#5891) Previous code could potentially dereference nil - this PR ensures that the poster is loaded before dereferencing it. Signed-off-by: Andrew Thornton <art27@cantab.net>
Signed-off-by: Andrew Thornton <art27@cantab.net>
adelowo
reviewed
Jan 29, 2019
| names = append(names, participants[i].Name) | ||
| } | ||
|
|
||
| if err := issue.loadRepo(e); err != nil { |
Contributor
Author
There was a problem hiding this comment.
Yup as per: #5891 (comment)
I noticed another nil dereference.
Contributor
Author
There was a problem hiding this comment.
Happy to remove and do another PR if preferred.
Member
There was a problem hiding this comment.
Ideally, I'd prefer it in another PR since backports are basically cherrypicked.
Contributor
Author
There was a problem hiding this comment.
The only trouble is that the PR doesn't then completely fix the bug...
@techknowlogick Should we keep the repo fix in this PR or make another with it separately?
Contributor
Author
Member
There was a problem hiding this comment.
Yeah, preferably two PRs for the reasons @adelowo listed above. However in this case I think we can keep it as one PR.
adelowo
approved these changes
Jan 29, 2019
techknowlogick
approved these changes
Jan 29, 2019
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous code could potentially dereference nil - this PR ensures
that the poster and the repo are loaded before dereferencing them.
#5891
Signed-off-by: Andrew Thornton art27@cantab.net