Modify linkRegex to require http|https#6171
Merged
Merged
Conversation
Modify the current linkRegex to require http|https which appears to be the intended behavior based on the comments. Right now, it also matches anything starting with www as well. Also add testing for linkRegex
Codecov Report
@@ Coverage Diff @@
## master #6171 +/- ##
==========================================
- Coverage 38.86% 38.85% -0.01%
==========================================
Files 354 354
Lines 50210 50210
==========================================
- Hits 19514 19510 -4
- Misses 27869 27874 +5
+ Partials 2827 2826 -1
Continue to review full report at Codecov.
|
Member
|
Is this a break change? |
Contributor
|
Well the current situation is that the auto links to say www.google.com just don't work and have never worked. |
lunny
approved these changes
Feb 28, 2019
Member
|
So this should be back port to release/v1.7 |
Member
|
Please send back port to release/v1.7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ugh sorry this is the same as #6153 which I broke by deleting my branch (which github didn't like)
Anyway, this is the same request to modify linkRegex so it only matches text starting with http|https when creating links. I've also added the requested tests for this to the current test suite as well.