Skip to content

Update bleve dependency to latest master revision#6100

Merged
techknowlogick merged 4 commits into
go-gitea:masterfrom
lunny:lunny/update_bleve
Feb 18, 2019
Merged

Update bleve dependency to latest master revision#6100
techknowlogick merged 4 commits into
go-gitea:masterfrom
lunny:lunny/update_bleve

Conversation

@lunny

@lunny lunny commented Feb 17, 2019

Copy link
Copy Markdown
Member

will unblock #5044

@codecov-io

codecov-io commented Feb 17, 2019

Copy link
Copy Markdown

Codecov Report

Merging #6100 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6100   +/-   ##
=======================================
  Coverage   38.86%   38.86%           
=======================================
  Files         345      345           
  Lines       49510    49510           
=======================================
  Hits        19241    19241           
  Misses      27486    27486           
  Partials     2783     2783

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e3166...c31b4a1. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2019
@techknowlogick techknowlogick added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Feb 17, 2019
Comment thread Gopkg.toml Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Near bottom of this file you can remove constraint on github.com/go-gitea/bolt"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should still fix revision to have predictable build

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lafriks done.

@lunny lunny force-pushed the lunny/update_bleve branch from 3b04f30 to 98ee0cb Compare February 17, 2019 14:35
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2019
@lafriks lafriks changed the title update bleve to master b17287a86f6cac923a5d886e10618df994eeb54b6724eac2e3b8dde89cfbe3a2 Update bleve dependency to latest master revision Feb 17, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 17, 2019
@zeripath

Copy link
Copy Markdown
Contributor

Needs a milestone setting... 1.8.0 or 1.9.0?

@techknowlogick

Copy link
Copy Markdown
Member

I’m going to set as 1.8 because it is a requirement to make this switch for go modules

@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 18, 2019
@techknowlogick techknowlogick merged commit a380cfd into go-gitea:master Feb 18, 2019
@lunny lunny deleted the lunny/update_bleve branch February 18, 2019 03:11
@lunny lunny mentioned this pull request Feb 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants