Skip to content

Add support for client basic auth for exchanging access tokens#6293

Merged
lunny merged 5 commits into
go-gitea:masterfrom
jonasfranz:feature/oauth2-basic-auth
Mar 11, 2019
Merged

Add support for client basic auth for exchanging access tokens#6293
lunny merged 5 commits into
go-gitea:masterfrom
jonasfranz:feature/oauth2-basic-auth

Conversation

@jonasfranz

@jonasfranz jonasfranz commented Mar 9, 2019

Copy link
Copy Markdown
Member

Adds support for basic auth for exchanging access tokens. This is important since golang's oauth2 library requires that.

https://tools.ietf.org/html/rfc6749#section-2.3.1

@jonasfranz jonasfranz added the type/enhancement An improvement of existing functionality label Mar 9, 2019
@jonasfranz jonasfranz added this to the 1.8.0 milestone Mar 9, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 9, 2019
@lafriks

lafriks commented Mar 9, 2019

Copy link
Copy Markdown
Member

Test seems to fail with empty client id

@codecov-io

codecov-io commented Mar 10, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@e0eb651). Click here to learn what that means.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6293   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      358           
  Lines             ?    51038           
  Branches          ?        0           
=========================================
  Hits              ?    19839           
  Misses            ?    28329           
  Partials          ?     2870
Impacted Files Coverage Δ
routers/user/oauth.go 38.88% <39.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0eb651...c5e9a70. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2019
@lunny lunny merged commit 2315019 into go-gitea:master Mar 11, 2019
@gsantner

gsantner commented Mar 19, 2019 •
edited
Loading

Copy link
Copy Markdown

@jonasfranz / @zeripath
Hey!
I'm running the daily version git-ca46385, tried to backup, but can't due missing tables.
Guess theres DB migration missing or like that?

gitea dump -c ~/gitea/custom/conf/app.ini 
2019/03/19 17:06:11 Creating tmp work dir: /tmp/gitea-dump-640591686
2019/03/19 17:06:11 Packing dump files...
2019/03/19 17:06:11 Dumping local repositories.../home/git/gitea/data/repositories
2019/03/19 17:07:39 Dumping database...
2019/03/19 17:07:40 Failed to dump database: Error 1146: Table 'gitea.o_auth2_application' doesn't exist

@jolheiser

jolheiser commented Mar 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Just a note for whoever looks at this, since I don't know enough about Xorm's backend.
The OAuth2Application struct is stored as oauth2_application which is why it can't find o_auth2_application when dumping.

gitea/models/oauth2_application.go

Lines 43 to 46 in e777c6b

// TableName sets the table name to `oauth2_application`
func (app *OAuth2Application) TableName() string {
return "oauth2_application"
}

@jonasfranz

jonasfranz commented Mar 19, 2019

Copy link
Copy Markdown
Member Author

That's not caused by this pull request. Please open up a new issue to better manage the bug.

@gsantner

gsantner commented Mar 20, 2019

Copy link
Copy Markdown

#6385 / #6310

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

8 participants

@jonasfranz @lafriks @codecov-io @gsantner @jolheiser @zeripath @lunny @GiteaBot