Add "ghost" and "notifications" to list of reserved user names.#6208
Merged
techknowlogick merged 1 commit intoFeb 28, 2019
Merged
Conversation
adelowo
approved these changes
Feb 27, 2019
Member
|
+1 for ghost. That's crazy |
Codecov Report
@@ Coverage Diff @@
## master #6208 +/- ##
==========================================
- Coverage 38.87% 38.87% -0.01%
==========================================
Files 354 354
Lines 50198 50198
==========================================
- Hits 19516 19514 -2
- Misses 27856 27859 +3
+ Partials 2826 2825 -1
Continue to review full report at Codecov.
|
zeripath
approved these changes
Feb 27, 2019
lafriks
approved these changes
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Username "ghost" should not be allowed, because it's a placeholder for deleted users. Username "notifications" should not be allowed, because it collides with the notifications URL.