Skip to content

full directory support for wiki#7390

Closed
Cherrg wants to merge 4 commits into
go-gitea:mainfrom
Cherrg:wiki_directories
Closed

full directory support for wiki#7390
Cherrg wants to merge 4 commits into
go-gitea:mainfrom
Cherrg:wiki_directories

Conversation

@Cherrg

@Cherrg Cherrg commented Jul 8, 2019

Copy link
Copy Markdown
Contributor

directory support for wiki

previously this was part of #7225 - lets split it up

This PR

  • add support for directories inside wiki. Create/update/delete pages works well. If an old page is updated, the file will be moved to subdirectory.
    • allows to read files with nearly all letters, as it is possible to push all via wiki gitrepo
      • files can exists in old and new structure.
        • files are selected by link, so it is possible to access and view both
        • writing to one of them will delete both, and create new one in directory structure
        • delete will delete the selected file
    • support images relative to directory path
      • fix preview on preview rendering
    • fix 500 error if wiki contains pages with invalid uri encoding (e.g. filename: badescaping%%.md)
  • ui fixes
    • add button 'Abort' to wiki edit and new page

fix #823

Signed-off-by: Michael Gnehr michael@gnehr.de

Cherrg added 4 commits July 9, 2019 01:21
@Cherrg
wiki make delete wiki keywords start with _
eff8e19 
+ add _delete to reserved keywords

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg
multi directory support + tests
9b34073 
see go-gitea#7225 for more details

Signed-off-by: Michael Gnehr <michael@gnehr.de>
@Cherrg
Merge branch 'master' into wiki_directories
0fc3a70
@Cherrg
update css file
d10e0fd 
Signed-off-by: Michael Gnehr <michael@gnehr.de>
@codecov-io

codecov-io commented Jul 9, 2019

Copy link
Copy Markdown

Codecov Report

Merging #7390 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7390      +/-   ##
==========================================
+ Coverage   41.19%   41.22%   +0.03%     
==========================================
  Files         469      469              
  Lines       63536    63635      +99     
==========================================
+ Hits        26171    26235      +64     
- Misses      33943    33970      +27     
- Partials     3422     3430       +8
Impacted Files Coverage Δ
modules/markup/markdown/markdown.go 80.95% <ø> (+2.24%) ⬆️
routers/routes/routes.go 82.38% <100%> (+0.02%) ⬆️
routers/repo/wiki.go 40.95% <55.35%> (+0.07%) ⬆️
models/wiki.go 59.72% <72.63%> (+2.84%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3f749...d10e0fd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2019
@lunny

lunny commented Sep 6, 2019

Copy link
Copy Markdown
Member

Please resolve the conflicts

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 6, 2019
lafriks
lafriks reviewed Sep 6, 2019
View reviewed changes
Comment thread models/wiki.go

gitRepo, err := git.OpenRepository(basePath)

fmt.Println(reflect.TypeOf(gitRepo))

@lafriks lafriks Sep 6, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

@stale

stale Bot commented Nov 5, 2019

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale Bot added the issue/stale label Nov 5, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Nov 5, 2019
@stale stale Bot removed the issue/stale label Nov 5, 2019
@lucastucious lucastucious mentioned this pull request Nov 9, 2019
Closed
@Cherrg Cherrg mentioned this pull request Nov 16, 2019
Closed
@lunny lunny added this to the 1.11.0 milestone Nov 16, 2019
@Cherrg Cherrg mentioned this pull request Nov 16, 2019
Merged
@lunny

lunny commented Dec 13, 2019

Copy link
Copy Markdown
Member

Please resolve the conflicts.

@gsantner

gsantner commented Dec 15, 2019

Copy link
Copy Markdown

@Cherrg

@lunny lunny modified the milestones: 1.11.0, 1.12.0 Dec 17, 2019
@ferrydeboer

ferrydeboer commented Mar 26, 2020 •
edited
Loading

Copy link
Copy Markdown

Well, this is a bit frustrating seeing this stale PR. Would really appreciate this feature. :( To bad I'm not proficient at Go.

@lunny lunny modified the milestones: 1.12.0, 1.x.x May 2, 2020
@a1012112796 a1012112796 mentioned this pull request Jul 16, 2021
Closed
@SieDa SieDa mentioned this pull request Oct 20, 2021
Open
@lunny lunny removed this from the 1.x.x milestone Jan 18, 2023
@wxiaoguang

wxiaoguang commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

This PR has been stale for long time, and the Wiki Title problem has been improved by #24143

Would there be new progress of this PR?

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 25, 2023
@wxiaoguang

wxiaoguang commented May 1, 2023

Copy link
Copy Markdown
Contributor

It has been stale for a long time and I can't think of a way to handling it other than closing it. Feel free to reopen if there's any new progress and I could also help.

@wxiaoguang wxiaoguang closed this May 1, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lafriks lafriks lafriks left review comments

Assignees

No one assigned

Labels

issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hierarchy (sub directory) in Wiki

8 participants

@Cherrg @codecov-io @lunny @gsantner @ferrydeboer @wxiaoguang @lafriks @GiteaBot