Skip to content

Redirects for renamed repos#807

Merged
lunny merged 2 commits into
go-gitea:masterfrom
ethantkoenig:redirect
Feb 5, 2017
Merged

Redirects for renamed repos#807
lunny merged 2 commits into
go-gitea:masterfrom
ethantkoenig:redirect

Conversation

@ethantkoenig
Copy link
Copy Markdown
Member

@ethantkoenig ethantkoenig commented Feb 1, 2017

Adds a new table (repo_redirect) to track what previous names should be redirected to.

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 1, 2017
@lunny lunny added this to the 1.1.0 milestone Feb 1, 2017
@lunny
Copy link
Copy Markdown
Member

lunny commented Feb 2, 2017

But if A -> B, but C -> A, then A will never be visit?

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 2, 2017
@ethantkoenig
Copy link
Copy Markdown
Member Author

ethantkoenig commented Feb 2, 2017

@lunny Good point, there are a lot of bugs with reusing previously-used repo names. I'll work on finding a solution.

@ethantkoenig ethantkoenig force-pushed the redirect branch 2 times, most recently from 0dc913c to 493093b Compare February 2, 2017 17:59
@ethantkoenig
Copy link
Copy Markdown
Member Author

ethantkoenig commented Feb 2, 2017

@lunny I've added changes so that whenever a repo is created or renamed, any redirects from the new name are deleted. I believe this should fix the problem.

lunny
lunny requested changes Feb 3, 2017
View reviewed changes
Comment thread models/repo_redirect.go Outdated
Copy link
Copy Markdown
Member

@lunny lunny Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like you use a database transaction to do that.

Copy link
Copy Markdown
Member

@lunny lunny Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Copy link
Copy Markdown
Member Author

@ethantkoenig ethantkoenig Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 😀

@ethantkoenig ethantkoenig force-pushed the redirect branch 2 times, most recently from 8239949 to 55b8a83 Compare February 3, 2017 04:03
lunny
lunny reviewed Feb 3, 2017
View reviewed changes
Comment thread templates/repo/settings/options.tmpl Outdated
Copy link
Copy Markdown
Member

@lunny lunny Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why remove the prompt?

Copy link
Copy Markdown
Member Author

@ethantkoenig ethantkoenig Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompt warns that "This change will affect how links relate to the repository". Once we have redirects, what the prompt says will no longer be true.

Copy link
Copy Markdown
Member

@lunny lunny Feb 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@lunny
Copy link
Copy Markdown
Member

lunny commented Feb 3, 2017

Otherwise LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 3, 2017
@bkcsoft
Copy link
Copy Markdown
Contributor

bkcsoft commented Feb 3, 2017

If I remember correcly, the way github does it is to redirect for X period of time, during that time no new repo can be created with that name. Sounds good?

@ethantkoenig
Copy link
Copy Markdown
Member Author

ethantkoenig commented Feb 3, 2017 •
edited
Loading

@bkcsoft Github lets you create a new repo with the old name immediately; I just checked. Perhaps it used to be as you described, but not anymore?

I also don't know about whether Github redirects expire. I haven't found any sources that explicitly say one way or another, and I can't easily test for myself 😄

@lunny
Copy link
Copy Markdown
Member

lunny commented Feb 5, 2017

conflicted

@appleboy
Copy link
Copy Markdown
Member

appleboy commented Feb 5, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 5, 2017
@lunny lunny merged commit 027591a into go-gitea:master Feb 5, 2017
@ethantkoenig ethantkoenig deleted the redirect branch February 6, 2017 02:38
@lunny
Copy link
Copy Markdown
Member

lunny commented Feb 7, 2017

resolved #806

@kasbah kasbah mentioned this pull request Dec 28, 2019
Closed
@AndrewBezold AndrewBezold mentioned this pull request May 28, 2020
Merged
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.

Projects

None yet

Milestone

1.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ethantkoenig @lunny @bkcsoft @appleboy @tboerger