fix bug pull request files will be broken if head repo was transfered to another user or orgnization#8571
Merged
lunny merged 1 commit intoOct 18, 2019
Conversation
… to another user or orgnization
zeripath
approved these changes
Oct 18, 2019
Contributor
|
Would it not be possible to replace every call to headusername with the equivalent looking up from the headrepo id? |
Member
Author
|
@zeripath Did you mean we will not drop that column, but we could do not use that column? |
lafriks
approved these changes
Oct 18, 2019
Member
|
@lunny that could probably be better |
Member
|
we can leave that column for 1.9 and drop only in 1.10 but fix not to use it already in 1.9 |
Member
Author
|
@lafriks drop column cannot be in v1.10 I think, only in v1.11 since release v1.10 branched. |
Member
|
It can, as long as no PR is merged that has migration that won't be backported and migrations does not go out of sync for 1.10 and master branches |
Member
Author
|
OK. So please review #8564 at first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8563, but this PR will not fix the broken pull requests because the bug because we cannot add a migration on this release branch. There are two workarounds to fix that.
head_user_nameto the correct one on tablepull_request.This PR is a manually back port from #8564 .