Skip to content

Allow list collaborators for users with Read access to repo #9995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
techknowlogick merged 2 commits into from
Apr 21, 2020
Merged

Allow list collaborators for users with Read access to repo #9995

techknowlogick merged 2 commits into from
Apr 21, 2020

Conversation

@shashvat-kedia
Copy link
Contributor

@shashvat-kedia shashvat-kedia commented Jan 26, 2020

Fix for issue #9956.

lunny
lunny requested changes Jan 26, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 26, 2020
@shashvat-kedia shashvat-kedia force-pushed the Fix-9956 branch 2 times, most recently from fe8b9aa to bfe47b1 Compare January 26, 2020 09:23
davidsvantesson
davidsvantesson reviewed Jan 26, 2020
View reviewed changes
@codecov-io
Copy link

codecov-io commented Jan 26, 2020 •
edited
Loading

Codecov Report

Merging #9995 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9995      +/-   ##
==========================================
- Coverage   43.69%   43.68%   -0.01%     
==========================================
  Files         586      586              
  Lines       81354    81354              
==========================================
- Hits        35548    35542       -6     
- Misses      41406    41412       +6     
  Partials     4400     4400
Impacted Files Coverage Δ
routers/api/v1/api.go 75.35% <100%> (ø) ⬆️
modules/process/manager.go 74.69% <0%> (-3.62%) ⬇️
models/unit.go 37.03% <0%> (-2.47%) ⬇️
services/pull/pull.go 35.19% <0%> (-0.88%) ⬇️
routers/repo/view.go 36.06% <0%> (-0.69%) ⬇️
models/gpg_key.go 55.37% <0%> (+0.55%) ⬆️
modules/queue/workerpool.go 58% <0%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71d5a09...2ac5009. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 26, 2020
@6543
Copy link
Member

6543 commented Jan 26, 2020

@SD1998 can you make fmt and commit the result?

6543
6543 reviewed Jan 26, 2020
View reviewed changes
6543
6543 reviewed Jan 26, 2020
View reviewed changes
6543
6543 reviewed Jan 26, 2020
View reviewed changes
6543
6543 reviewed Jan 26, 2020
View reviewed changes
@davidsvantesson
Copy link
Contributor

davidsvantesson commented Feb 4, 2020

@SD1998 Do you have possibility to install gitea build tools (https://docs.gitea.io/en-us/hacking-on-gitea/) and run make fmt? Continuous integration is picky about style and it can be hard to get it right manually.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 23, 2020
6543
6543 approved these changes Feb 23, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@6543
Copy link
Member

6543 commented Feb 23, 2020 •
edited
Loading

@SD1998 just update branch and CI will restart ...

@shashvat-kedia
Copy link
Contributor Author

shashvat-kedia commented Feb 23, 2020 •
edited
Loading

@6543 Done.

@guillep2k
Copy link
Member

guillep2k commented Feb 23, 2020

@lunny your review is required.

@lafriks lafriks added the type/enhancement An improvement of existing functionality label Feb 27, 2020
@lafriks lafriks added this to the 1.12.0 milestone Feb 27, 2020
@6543
Copy link
Member

6543 commented Apr 20, 2020

@SD1998 can you "update" :)

@techknowlogick techknowlogick requested a review from lunny April 20, 2020 23:20
@techknowlogick
Copy link
Member

techknowlogick commented Apr 20, 2020

@lunny need your review

@jolheiser jolheiser requested review from lunny and removed request for lunny April 20, 2020 23:29
@techknowlogick
Copy link
Member

techknowlogick commented Apr 21, 2020

ping LG-TM

@techknowlogick techknowlogick merged commit 74cc3c5 into go-gitea:master Apr 21, 2020
@lunny lunny mentioned this pull request May 2, 2020
Closed
@mecseid mecseid mentioned this pull request Jun 13, 2020
Merged
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@shashvat-kedia @lunny
Allow list collaborators for users with Read access to repo (go-gitea…
efe8a52 
…#9995)

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lunny lunny lunny approved these changes

@lafriks lafriks lafriks approved these changes

@6543 6543 6543 approved these changes

+1 more reviewer

@davidsvantesson davidsvantesson davidsvantesson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality

Projects

None yet

Milestone

1.12.0

Development

Successfully merging this pull request may close these issues.

9 participants

@shashvat-kedia @codecov-io @6543 @davidsvantesson @guillep2k @techknowlogick @lunny @lafriks @GiteaBot