Skip to content
This repository was archived by the owner on Oct 30, 2025. It is now read-only.

lhef: reduce number of allocs in Decoder#938

Merged
sbinet merged 3 commits into
go-hep:mainfrom
dolmen-go:lhef-Decoder-reduce-allocs
May 10, 2022
Merged

lhef: reduce number of allocs in Decoder#938
sbinet merged 3 commits into
go-hep:mainfrom
dolmen-go:lhef-Decoder-reduce-allocs

Conversation

@dolmen
Copy link
Copy Markdown
Contributor

@dolmen dolmen commented Apr 27, 2022

In the lhef.Decoder, allocate slices using sliced bigger chunks in order to reduce the number of allocations.

Example:

a := make([]int32, n)
b := make([]int32, n)
c := make([]int32, n)

is replaced with:

n32 := make([]int32, 3*n)
a := n32[:n:n]
b := n32[n : 2*n : 2*n]
b := n32[2*n:]

dolmen added 3 commits April 27, 2022 22:49
@dolmen
lhef: reduce allocs in NewDecoder
d13b937 
Allocate arrays in one block in lhef.NewDecoder.
@dolmen
lhef: more Decoder tests
1f7aaf1
@dolmen
lhef: reduce allocs on event decoding
246c5de 
When decoding an event block, allocate memory for slices in bigger
blocks to reduce the number of memory allocations.
sbinet
sbinet approved these changes Apr 28, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for improving this. (it feels like good old FORTRAN column blocks, but hey :P)

@sbinet sbinet merged commit 1992369 into go-hep:main May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sbinet sbinet sbinet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dolmen @sbinet