Skip to content
This repository was archived by the owner on Oct 30, 2025. It is now read-only.

all: modernize Go usage#1038

Merged
sbinet merged 1 commit into
go-hep:mainfrom
sbinet-hep:modernize
Mar 7, 2025
Merged

all: modernize Go usage#1038
sbinet merged 1 commit into
go-hep:mainfrom
sbinet-hep:modernize

Conversation

@sbinet
Copy link
Copy Markdown
Member

@sbinet sbinet commented Mar 7, 2025

This commit modernizes Go usage.
This was done with:

$> go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Then files needed to be go fmted and a few comments needed to be restored.

The modernizations include replacing

  • if/else conditional assignment by a call to the built-in min or max functions added in go1.21
  • sort.Slice(x, func(i, j int) bool) { return s[i] < s[j] } by a call to slices.Sort(s), added in go1.21
  • interface{} by the 'any' type added in go1.18
  • append([]T(nil), s...) by slices.Clone(s) or slices.Concat(s), added in go1.21
  • loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21
  • []byte(fmt.Sprintf...) by fmt.Appendf(nil, ...), added in go1.19
  • append(s[:i], s[i+1]...) by slices.Delete(s, i, i+1), added in go1.21
  • a 3-clause for i := 0; i < n; i++ {} loop by for i := range n {}, added in go1.22

This commit modernizes Go usage.
This was done with:

```
$> go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
```

Then files needed to be `go fmt`ed and a few comments needed to be restored.

The modernizations include replacing

- if/else conditional assignment by a call to the built-in min or max functions added in go1.21
- sort.Slice(x, func(i, j int) bool) { return s[i] < s[j] } by a call to slices.Sort(s), added in go1.21
- interface{} by the 'any' type added in go1.18
- append([]T(nil), s...) by slices.Clone(s) or slices.Concat(s), added in go1.21
- loop around an m[k]=v map update by a call to one of the Collect, Copy, Clone, or Insert functions from the maps package, added in go1.21
- []byte(fmt.Sprintf...) by fmt.Appendf(nil, ...), added in go1.19
- append(s[:i], s[i+1]...) by slices.Delete(s, i, i+1), added in go1.21
- a 3-clause for i := 0; i < n; i++ {} loop by for i := range n {}, added in go1.22

Signed-off-by: Sebastien Binet <binet@cern.ch>
@sbinet sbinet merged commit fc7e544 into go-hep:main Mar 7, 2025
@sbinet sbinet deleted the modernize branch March 7, 2025 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant