struct: correctly mapping non unique sections to slice field#242
Merged
unknwon merged 2 commits intogo-ini:masterfrom May 28, 2020
Merged
struct: correctly mapping non unique sections to slice field#242unknwon merged 2 commits intogo-ini:masterfrom
unknwon merged 2 commits intogo-ini:masterfrom
Conversation
…sections in some special cases
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
- Coverage 86.41% 86.25% -0.16%
==========================================
Files 9 9
Lines 1884 1885 +1
==========================================
- Hits 1628 1626 -2
- Misses 196 198 +2
- Partials 60 61 +1
|
unknwon
approved these changes
May 28, 2020
Member
|
New release tagged: https://github.com/go-ini/ini/releases/tag/v1.57.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem should be fixed?
The problem in #241
Have you added test cases to catch the problem?
Yes, I added a test case for the case pointed out in the issue #241 by tevino.