Skip to content

perf(config/env): use strings.LastIndexByte instead of strings.LastIndex #3660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2025
Merged

perf(config/env): use strings.LastIndexByte instead of strings.LastIndex #3660

merged 3 commits into from
Jul 16, 2025

Conversation

@1911860538
Copy link
Contributor

@1911860538 1911860538 commented May 13, 2025

strings.LastIndexByte offers better performance than strings.LastIndex.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 13, 2025
demoManito
demoManito previously approved these changes May 13, 2025
View reviewed changes
@dosubot dosubot bot added the LGTM label May 13, 2025
kagaya85
kagaya85 previously approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@kagaya85 kagaya85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kagaya85
Copy link
Member

kagaya85 commented Jul 14, 2025 •
edited
Loading

Maybe we should include a benchmark test for performance-related changes @1911860538

@1911860538
Copy link
Contributor Author

1911860538 commented Jul 14, 2025

Maybe we should include a benchmark test for performance-related changes @1911860538

Ok, I will update this PR after today's work.

@1911860538 1911860538 dismissed stale reviews from kagaya85 and demoManito via 9f609d0 July 14, 2025 12:28
@1911860538
Copy link
Contributor Author

1911860538 commented Jul 14, 2025

Maybe we should include a benchmark test for performance-related changes @1911860538

benchmark code

func BenchmarkFormat(b *testing.B) {
	for i := 0; i < b.N; i++ {
		format("abc.txt")
	}
}

benchmark output before optimization

goos: darwin
goarch: amd64
pkg: github.com/go-kratos/kratos/v2/config/file
cpu: Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
BenchmarkFormat
BenchmarkFormat-8   	276620788	         4.317 ns/op
PASS

Process finished with the exit code 0

benchmark output after optimization

goos: darwin
goarch: amd64
pkg: github.com/go-kratos/kratos/v2/config/file
cpu: Intel(R) Core(TM) i7-8569U CPU @ 2.80GHz
BenchmarkFormat
BenchmarkFormat-8   	338712090	         3.683 ns/op
PASS

Process finished with the exit code 0

@kagaya85
Copy link
Member

kagaya85 commented Jul 15, 2025

Thanks for the update, please rebase the code☺️

@1911860538
Copy link
Contributor Author

1911860538 commented Jul 15, 2025

Thanks for the update, please rebase the code☺️

Done.

@kagaya85 kagaya85 merged commit ac92cbe into go-kratos:main Jul 16, 2025
35 checks passed
@shenqidebaozi shenqidebaozi mentioned this pull request Sep 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Cluas Cluas Cluas approved these changes

@kagaya85 kagaya85 kagaya85 approved these changes

@demoManito demoManito demoManito left review comments

Assignees

No one assigned

Labels

LGTM size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@1911860538 @kagaya85 @Cluas @demoManito