worker: release messages without defer#167
Open
ddevault wants to merge 1 commit into
Open
Conversation
defer causes the function calls to occur at the termination of the function, rather than at the end of the current block. This causes defers within a loop to build up a large list of calls in memory and doesn't run them until the worker terminates, causing a memory leak. This also fixes a nil pointer dereference when the result is nil - for example, if runTaskFunc's taskFunc.Call calls a worker function with no return value.
Author
|
The lint error appears to be unrelated to my change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
defer causes the function calls to occur at the termination of the
function, rather than at the end of the current block. This causes
defers within a loop to build up a large list of calls in memory and
doesn't run them until the worker terminates, causing a memory leak.
This also fixes a nil pointer dereference when the result is nil - for
example, if runTaskFunc's taskFunc.Call calls a worker function with no
return value.